The patch titled
spi/mpc8xxx: don't check platform_get_irq's return value against zero
has been removed from the -mm tree. Its filename was
spi-mpc8xxx-dont-check-platform_get_irqs-return-value-against-zero.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: spi/mpc8xxx: don't check platform_get_irq's return value against zero
From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
platform_get_irq returns -ENXIO on failure, so !irq was probably always
true. Make irq a signed variable and compare irq <= 0. Note that a
return value of zero is still handled as error even though this could mean
irq0.
This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 ("driver
core: platform_get_irq*(): return -ENXIO on error") which changed the
return value of platform_get_irq from 0 to -ENXIO on error.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Cc: David Vrabel <dvrabel@xxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxx>
Cc: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
Cc: Grant Likely <grant.likely@xxxxxxxxxxxx>
Cc: Kumar Gala <galak@xxxxxxxxxxxxxxxxxxx>
Cc: Anton Vorontsov <avorontsov@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/spi/spi_mpc8xxx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN drivers/spi/spi_mpc8xxx.c~spi-mpc8xxx-dont-check-platform_get_irqs-return-value-against-zero drivers/spi/spi_mpc8xxx.c
--- a/drivers/spi/spi_mpc8xxx.c~spi-mpc8xxx-dont-check-platform_get_irqs-return-value-against-zero
+++ a/drivers/spi/spi_mpc8xxx.c
@@ -1328,7 +1328,7 @@ static struct of_platform_driver of_mpc8
static int __devinit plat_mpc8xxx_spi_probe(struct platform_device *pdev)
{
struct resource *mem;
- unsigned int irq;
+ int irq;
struct spi_master *master;
if (!pdev->dev.platform_data)
@@ -1339,7 +1339,7 @@ static int __devinit plat_mpc8xxx_spi_pr
return -EINVAL;
irq = platform_get_irq(pdev, 0);
- if (!irq)
+ if (irq <= 0)
return -EINVAL;
master = mpc8xxx_spi_probe(&pdev->dev, mem, irq);
_
Patches currently in -mm which might be from u.kleine-koenig@xxxxxxxxxxxxxx are
origin.patch
linux-next.patch
mtd-nand-fix-build-failure-caused-by-typo.patch
hrtimer-correct-a-few-numbers-in-comments.patch
clockevents-ensure-taht-min_delta_ns-is-increased-in-error-path.patch
genirq-warn-about-irqf_sharedirqf_disabled-at-the-right-place.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
