The patch titled drivers/misc/iwmc3200top/main.c: eliminate useless code has been added to the -mm tree. Its filename is drivers-misc-iwmc3200top-mainc-eliminate-useless-code.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: drivers/misc/iwmc3200top/main.c: eliminate useless code From: Julia Lawall <julia@xxxxxxx> The variable priv is initialized twice to the same (side effect-free) expression. Drop one initialization. A simplified version of the semantic match that finds this problem is: (http://coccinelle.lip6.fr/) // <smpl> @forall@ idexpression *x; identifier f!=ERR_PTR; @@ x = f(...) ... when != x ( x = f(...,<+...x...+>,...) | * x = f(...) ) // </smpl> Signed-off-by: Julia Lawall <julia@xxxxxxx> Cc: Tomas Winkler <tomas.winkler@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/misc/iwmc3200top/main.c | 2 -- 1 file changed, 2 deletions(-) diff -puN drivers/misc/iwmc3200top/main.c~drivers-misc-iwmc3200top-mainc-eliminate-useless-code drivers/misc/iwmc3200top/main.c --- a/drivers/misc/iwmc3200top/main.c~drivers-misc-iwmc3200top-mainc-eliminate-useless-code +++ a/drivers/misc/iwmc3200top/main.c @@ -597,8 +597,6 @@ static void iwmct_remove(struct sdio_fun struct iwmct_work_struct *read_req; struct iwmct_priv *priv = sdio_get_drvdata(func); - priv = sdio_get_drvdata(func); - LOG_INFO(priv, INIT, "enter\n"); sdio_claim_host(func); _ Patches currently in -mm which might be from julia@xxxxxxx are linux-next.patch drivers-scsi-sesc-eliminate-double-free.patch kernel-credc-use-kmem_cache_free.patch arch-arm-plat-pxa-dmac-correct-null-test.patch drivers-gpu-drm-nouveau-nouveau_grctxc-correct-null-test.patch drivers-media-video-move-dereference-after-null-test.patch net-ipv4-correct-the-size-argument-to-kzalloc.patch drivers-scsi-libsas-use-sam_good.patch drivers-scsi-remove-unnecessary-null-test.patch drivers-message-move-dereference-after-null-test.patch drivers-scsi-correct-the-size-argument-to-kmalloc.patch drivers-staging-tm6000-tm6000-videoc-correct-null-test.patch drivers-misc-iwmc3200top-mainc-eliminate-useless-code.patch drivers-edac-introduce-missing-kfree.patch drivers-char-mmtimerc-eliminate-useless-code.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html