The patch titled ramzswap: use slot free callback to eliminate stale data has been removed from the -mm tree. Its filename was ramzswap-use-slot-free-callback-to-eliminate-stale-data.patch This patch was dropped because other changes were merged, which wrecked this patch The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: ramzswap: use slot free callback to eliminate stale data From: Nitin Gupta <ngupta@xxxxxxxxxx> ramzswap driver creates RAM backed block devices which are used as swap disks. Pages swapped to these disks are compressed and stored in memory itself. However, when a swap page becomes stale i.e. it is no longer referenced by any process (say, when owning process exits), the driver does not get any notification about this. So, it has to keep such pages in memory until kernel swaps to the same swap slot again thereby overwriting previous (stale) page. Often, a large number of such stale pages accumulate which defeats the whole purpose of in-memory compressed swapping and it begins to have a negative impact on system performance. To overcome this problem, we now register a callback function which is called as soon as a swap slot is freed which allows us to free corresponding memory, eliminating any stale data in (compressed) memory. Signed-off-by: Nitin Gupta <ngupta@xxxxxxxxxx> Acked-by: Hugh Dickins <hugh.dickins@xxxxxxxxxxxxx> Cc: Greg KH <greg@xxxxxxxxx> Cc: Pekka Enberg <penberg@xxxxxxxxxxxxxx> Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx> Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx> Cc: Jens Axboe <jens.axboe@xxxxxxxxxx> Cc: Andi Kleen <andi@xxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/staging/ramzswap/ramzswap_drv.c | 15 ++++++++++++++- drivers/staging/ramzswap/ramzswap_drv.h | 1 + drivers/staging/ramzswap/ramzswap_ioctl.h | 1 + 3 files changed, 16 insertions(+), 1 deletion(-) diff -puN drivers/staging/ramzswap/ramzswap_drv.c~ramzswap-use-slot-free-callback-to-eliminate-stale-data drivers/staging/ramzswap/ramzswap_drv.c --- a/drivers/staging/ramzswap/ramzswap_drv.c~ramzswap-use-slot-free-callback-to-eliminate-stale-data +++ a/drivers/staging/ramzswap/ramzswap_drv.c @@ -253,6 +253,7 @@ void ramzswap_ioctl_get_stats(struct ram s->failed_reads = rs->failed_reads; s->failed_writes = rs->failed_writes; s->invalid_io = rs->invalid_io; + s->notify_free = rs->notify_free; s->pages_zero = rs->pages_zero; s->good_compress_pct = good_compress_perc; @@ -1287,9 +1288,21 @@ out: return ret; } +void ramzswap_slot_free_notify(struct block_device *bdev, unsigned long index) +{ + struct ramzswap *rzs; + + rzs = bdev->bd_disk->private_data; + ramzswap_free_page(rzs, index); + stat_inc(rzs->stats.notify_free); + + return; +} + static struct block_device_operations ramzswap_devops = { .ioctl = ramzswap_ioctl, - .owner = THIS_MODULE, + .swap_slot_free_notify = ramzswap_slot_free_notify, + .owner = THIS_MODULE }; static void create_device(struct ramzswap *rzs, int device_id) diff -puN drivers/staging/ramzswap/ramzswap_drv.h~ramzswap-use-slot-free-callback-to-eliminate-stale-data drivers/staging/ramzswap/ramzswap_drv.h --- a/drivers/staging/ramzswap/ramzswap_drv.h~ramzswap-use-slot-free-callback-to-eliminate-stale-data +++ a/drivers/staging/ramzswap/ramzswap_drv.h @@ -124,6 +124,7 @@ struct ramzswap_stats { u64 failed_reads; /* can happen when memory is too low */ u64 failed_writes; /* should NEVER! happen */ u64 invalid_io; /* non-swap I/O requests */ + u64 notify_free; /* no. of swap slot free notifications */ u32 pages_zero; /* no. of zero filled pages */ u32 pages_stored; /* no. of pages currently stored */ u32 good_compress; /* % of pages with compression ratio<=50% */ diff -puN drivers/staging/ramzswap/ramzswap_ioctl.h~ramzswap-use-slot-free-callback-to-eliminate-stale-data drivers/staging/ramzswap/ramzswap_ioctl.h --- a/drivers/staging/ramzswap/ramzswap_ioctl.h~ramzswap-use-slot-free-callback-to-eliminate-stale-data +++ a/drivers/staging/ramzswap/ramzswap_ioctl.h @@ -27,6 +27,7 @@ struct ramzswap_ioctl_stats { u64 failed_reads; /* can happen when memory is too low */ u64 failed_writes; /* should NEVER! happen */ u64 invalid_io; /* non-swap I/O requests */ + u64 notify_free; /* no. of swap slot free notifications */ u32 pages_zero; /* no. of zero filled pages */ u32 good_compress_pct; /* no. of pages with compression ratio<=50% */ u32 pages_expand_pct; /* no. of incompressible pages */ _ Patches currently in -mm which might be from ngupta@xxxxxxxxxx are linux-next.patch mm-add-swap-slot-free-callback-to-block_device_operations.patch mm-add-swap-slot-free-callback-to-block_device_operations-fix.patch ramzswap-use-slot-free-callback-to-eliminate-stale-data.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html