The patch titled bluetooth: wrong variable tested has been added to the -mm tree. Its filename is bluetooth-wrong-variable-tested.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: bluetooth: wrong variable tested From: Roel Kluin <roel.kluin@xxxxxxxxx> The return of the function sdio_readb() was not tested. Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx> Cc: Marcel Holtmann <marcel@xxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/bluetooth/btmrvl_sdio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/bluetooth/btmrvl_sdio.c~bluetooth-wrong-variable-tested drivers/bluetooth/btmrvl_sdio.c --- a/drivers/bluetooth/btmrvl_sdio.c~bluetooth-wrong-variable-tested +++ a/drivers/bluetooth/btmrvl_sdio.c @@ -348,7 +348,7 @@ static int btmrvl_sdio_download_fw_w_hel for (tries = 0; tries < MAX_POLL_TRIES; tries++) { base0 = sdio_readb(card->func, SQ_READ_BASE_ADDRESS_A0_REG, &ret); - if (ret) { + if (base0) { BT_ERR("BASE0 register read failed:" " base0 = 0x%04X(%d)." " Terminating download", @@ -358,7 +358,7 @@ static int btmrvl_sdio_download_fw_w_hel } base1 = sdio_readb(card->func, SQ_READ_BASE_ADDRESS_A1_REG, &ret); - if (ret) { + if (base1) { BT_ERR("BASE1 register read failed:" " base1 = 0x%04X(%d)." " Terminating download", _ Patches currently in -mm which might be from roel.kluin@xxxxxxxxx are origin.patch zlib-optimize-inffast-when-copying-direct-from-output.patch linux-next.patch acpi-fix-confusion-in-acpi_evaluate_string-in-comment.patch powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned.patch hisax-timeout-off-by-one-in-waitrecmsg.patch bluetooth-wrong-variable-tested.patch drivers-scsi-fnic-fnic_scsic-clean-up.patch ibmmca-buffer-overflow.patch scsi-eata-fix-buffer-overflow.patch drivers-scsi-gdthc-fix-buffer-overflow.patch drivers-scsi-u14-34fc-fix-uffer-overflow.patch drivers-scsi-lpfc-lpfc_vportc-fix-read-buffer-overflow.patch osst-fix-read-buffer-overflow.patch gdth-unmap-ccb_phys-when-scsi_add_host-fails-in-gdth_eisa_probe_one.patch zfcp-test-kmalloc-failure-in-scsi_get_vpd_page.patch ncr5380-bit-mr_dma_mode-set-twice-in-ncr5380_transfer_dma.patch scsi-pmcraid-redundant-check-in-pmcraid_check_ioctl_buffer.patch dc395x-decrease-iteration-for-tag_number-of-max_command-in-start_scsi.patch mpt2sas-fix-confusion-in-_scsih_sas_device_status_change_event.patch paride-fix-off-by-one-test.patch 80211core-fix-confusion.patch frv-duplicate-output_buffer-of-e03.patch frv-duplicate-output_buffer-of-e03-checkpatch-fixes.patch cryptocop-fix-assertion-in-create_output_descriptors.patch asiliantfb-fix-test-of-unsigned-in-asiliant_calc_dclk2.patch w1-fix-test-in-ds2482_wait_1wire_idle.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html