The patch titled drivers/net/can/mcp251x.c: correct NULL test has been added to the -mm tree. Its filename is drivers-net-can-mcp251xc-correct-null-test.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: drivers/net/can/mcp251x.c: correct NULL test From: Julia Lawall <julia@xxxxxxx> Test the just-allocated value for NULL rather than some other value. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression x,y; statement S; @@ x = \(kmalloc\|kcalloc\|kzalloc\)(...); ( if ((x) == NULL) S | if ( - y + x == NULL) S ) // </smpl> Signed-off-by: Julia Lawall <julia@xxxxxxx> Cc: Urs Thuermann <urs.thuermann@xxxxxxxxxxxxx> Cc: Oliver Hartkopp <oliver.hartkopp@xxxxxxxxxxxxx> Cc: David S. Miller <davem@xxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/net/can/mcp251x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/net/can/mcp251x.c~drivers-net-can-mcp251xc-correct-null-test drivers/net/can/mcp251x.c --- a/drivers/net/can/mcp251x.c~drivers-net-can-mcp251xc-correct-null-test +++ a/drivers/net/can/mcp251x.c @@ -990,7 +990,7 @@ static int __devinit mcp251x_can_probe(s goto error_tx_buf; } priv->spi_rx_buf = kmalloc(SPI_TRANSFER_BUF_LEN, GFP_KERNEL); - if (!priv->spi_tx_buf) { + if (!priv->spi_rx_buf) { ret = -ENOMEM; goto error_rx_buf; } _ Patches currently in -mm which might be from julia@xxxxxxx are origin.patch linux-next.patch drivers-scsi-sesc-eliminate-double-free.patch kernel-credc-use-kmem_cache_free.patch drivers-media-video-move-dereference-after-null-test.patch arch-mips-alchemy-correct-code-taking-the-size-of-a-pointer.patch drivers-isdn-eliminate-duplicated-test.patch drivers-scsi-libsas-use-sam_good.patch drivers-scsi-remove-unnecessary-null-test.patch drivers-message-move-dereference-after-null-test.patch drivers-edac-introduce-missing-kfree.patch arch-arm-plat-pxa-dmac-correct-null-test.patch drivers-block-drbd-drbd_receiverc-correct-null-test.patch drivers-gpu-drm-nouveau-nouveau_grctxc-correct-null-test.patch drivers-net-can-mcp251xc-correct-null-test.patch drivers-staging-tm6000-tm6000-videoc-correct-null-test.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html