The patch titled
enclosure: fix oops while iterating enclosure_status array
has been removed from the -mm tree. Its filename was
enclosure-fix-oops-while-iterating-enclosure_status-array.patch
This patch was dropped because an alternative patch was merged
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: enclosure: fix oops while iterating enclosure_status array
From: Jeff Mahoney <jeffm@xxxxxxxxxxxxxxxxxx>
enclosure_status is expected to be a NULL terminated array of strings but
isn't actually NULL terminated. When writing an invalid value to
/sys/class/enclosure/.../.../status, it goes off the end of the array and
Oopses.
This patch uses the array size instead.
Reported-by: Artur Wojcik <artur.wojcik@xxxxxxxxx>
Signed-off-by: Jeff Mahoney <jeffm@xxxxxxxx>
Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/misc/enclosure.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff -puN drivers/misc/enclosure.c~enclosure-fix-oops-while-iterating-enclosure_status-array drivers/misc/enclosure.c
--- a/drivers/misc/enclosure.c~enclosure-fix-oops-while-iterating-enclosure_status-array
+++ a/drivers/misc/enclosure.c
@@ -441,8 +441,9 @@ static ssize_t set_component_status(stru
struct enclosure_component *ecomp = to_enclosure_component(cdev);
int i;
- for (i = 0; enclosure_status[i]; i++) {
- if (strncmp(buf, enclosure_status[i],
+ for (i = 0; i < ARRAY_SIZE(enclosure_status); i++) {
+ if (enclosure_status[i] &&
+ strncmp(buf, enclosure_status[i],
strlen(enclosure_status[i])) == 0 &&
(buf[strlen(enclosure_status[i])] == '\n' ||
buf[strlen(enclosure_status[i])] == '\0'))
_
Patches currently in -mm which might be from jeffm@xxxxxxxxxxxxxxxxxx are
enclosure-fix-oops-while-iterating-enclosure_status-array.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
