The patch titled drivers/cpuidle: Move dereference after NULL test has been removed from the -mm tree. Its filename was drivers-cpuidle-move-dereference-after-null-test.patch This patch was dropped because it was merged into mainline or a subsystem tree The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: drivers/cpuidle: Move dereference after NULL test From: Julia Lawall <julia@xxxxxxx> It does not seem possible that ldev can be NULL, so drop the unnecessary test. If ldev can somehow be NULL, then the initialization of last_idx should be moved below the test. A simplified version of the semantic match that detects this problem is as follows (http://coccinelle.lip6.fr/): // <smpl> @match exists@ expression x, E; identifier fld; @@ * x->fld ... when != \(x = E\|&x\) * x == NULL // </smpl> Signed-off-by: Julia Lawall <julia@xxxxxxx> Acked-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx> Cc: Ingo Molnar <mingo@xxxxxxx> Cc: Venkatesh Pallipadi <venkatesh.pallipadi@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/cpuidle/governors/ladder.c | 3 --- 1 file changed, 3 deletions(-) diff -puN drivers/cpuidle/governors/ladder.c~drivers-cpuidle-move-dereference-after-null-test drivers/cpuidle/governors/ladder.c --- a/drivers/cpuidle/governors/ladder.c~drivers-cpuidle-move-dereference-after-null-test +++ a/drivers/cpuidle/governors/ladder.c @@ -69,9 +69,6 @@ static int ladder_select_state(struct cp int last_residency, last_idx = ldev->last_state_idx; int latency_req = pm_qos_requirement(PM_QOS_CPU_DMA_LATENCY); - if (unlikely(!ldev)) - return 0; - /* Special case when user has set very strict latency requirement */ if (unlikely(latency_req == 0)) { ladder_do_selection(ldev, last_idx, 0); _ Patches currently in -mm which might be from julia@xxxxxxx are origin.patch linux-next.patch drivers-media-video-move-dereference-after-null-test.patch drivers-isdn-eliminate-duplicated-test.patch drivers-scsi-libsas-use-sam_good.patch drivers-scsi-remove-unnecessary-null-test.patch drivers-message-move-dereference-after-null-test.patch drivers-block-dac960c-use-dac960_v2_controller.patch drivers-usb-wusbcore-introduce-missing-usb_free_urb.patch drivers-video-move-dereference-after-null-test.patch drivers-char-ipmi-use-kcs_idle_state.patch drivers-edac-introduce-missing-kfree.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html