The patch titled
writeback: remove the always false bdi_cap_writeback_dirty() test
has been added to the -mm tree. Its filename is
writeback-remove-the-always-false-bdi_cap_writeback_dirty-test.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: writeback: remove the always false bdi_cap_writeback_dirty() test
From: Wu Fengguang <fengguang.wu@xxxxxxxxx>
This is dead code because no bdi flush thread will be started for
!bdi_cap_writeback_dirty bdi.
Signed-off-by: Wu Fengguang <fengguang.wu@xxxxxxxxx>
Cc: Jens Axboe <jens.axboe@xxxxxxxxxx>
Cc: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/fs-writeback.c | 18 ------------------
1 file changed, 18 deletions(-)
diff -puN fs/fs-writeback.c~writeback-remove-the-always-false-bdi_cap_writeback_dirty-test fs/fs-writeback.c
--- a/fs/fs-writeback.c~writeback-remove-the-always-false-bdi_cap_writeback_dirty-test
+++ a/fs/fs-writeback.c
@@ -615,7 +615,6 @@ static void writeback_inodes_wb(struct b
struct writeback_control *wbc)
{
struct super_block *sb = wbc->sb, *pin_sb = NULL;
- const int is_blkdev_sb = sb_is_blkdev_sb(sb);
const unsigned long start = jiffies; /* livelock avoidance */
spin_lock(&inode_lock);
@@ -636,23 +635,6 @@ static void writeback_inodes_wb(struct b
continue;
}
- if (!bdi_cap_writeback_dirty(wb->bdi)) {
- redirty_tail(inode);
- if (is_blkdev_sb) {
- /*
- * Dirty memory-backed blockdev: the ramdisk
- * driver does this. Skip just this inode
- */
- continue;
- }
- /*
- * Dirty memory-backed inode against a filesystem other
- * than the kernel-internal bdev filesystem. Skip the
- * entire superblock.
- */
- break;
- }
-
if (inode->i_state & (I_NEW | I_WILL_FREE)) {
requeue_io(inode);
continue;
_
Patches currently in -mm which might be from fengguang.wu@xxxxxxxxx are
writeback-remove-unused-nonblocking-and-congestion-checks-xfs.patch
writeback-remove-the-always-false-bdi_cap_writeback_dirty-test.patch
writeback-introduce-wbcfor_background.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
