The patch titled
mm/vsmcan: check shrink_active_list() sc->isolate_pages() return value
has been removed from the -mm tree. Its filename was
mm-vsmcan-check-shrink_active_list-sc-isolate_pages-return-value.patch
This patch was dropped because it was withdrawn
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: mm/vsmcan: check shrink_active_list() sc->isolate_pages() return value
From: Vincent Li <macli@xxxxxxxxxx>
If we can't isolate pages from LRU list, we don't have to account page
movement, either. Already, in commit 5343daceec, KOSAKI did it about
shrink_inactive_list.
This patch removes unnecessary overhead of page accounting and locking in
shrink_active_list as follow-up work of commit 5343daceec.
Signed-off-by: Vincent Li <macli@xxxxxxxxxx>
Reviewed-by: Minchan Kim <minchan.kim@xxxxxxxxx>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
Reviewed-by: Wu Fengguang <fengguang.wu@xxxxxxxxx>
Acked-by: Rik van Riel <riel@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/vmscan.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff -puN mm/vmscan.c~mm-vsmcan-check-shrink_active_list-sc-isolate_pages-return-value mm/vmscan.c
--- a/mm/vmscan.c~mm-vsmcan-check-shrink_active_list-sc-isolate_pages-return-value
+++ a/mm/vmscan.c
@@ -1333,9 +1333,12 @@ static void shrink_active_list(unsigned
if (scanning_global_lru(sc)) {
zone->pages_scanned += pgscanned;
}
- reclaim_stat->recent_scanned[file] += nr_taken;
-
__count_zone_vm_events(PGREFILL, zone, pgscanned);
+
+ if (nr_taken == 0)
+ goto done;
+
+ reclaim_stat->recent_scanned[file] += nr_taken;
if (file)
__mod_zone_page_state(zone, NR_ACTIVE_FILE, -nr_taken);
else
@@ -1393,6 +1396,7 @@ static void shrink_active_list(unsigned
move_active_pages_to_lru(zone, &l_inactive,
LRU_BASE + file * LRU_FILE);
__mod_zone_page_state(zone, NR_ISOLATED_ANON + file, -nr_taken);
+done:
spin_unlock_irq(&zone->lru_lock);
}
_
Patches currently in -mm which might be from macli@xxxxxxxxxx are
mm-vsmcan-check-shrink_active_list-sc-isolate_pages-return-value.patch
mm-vmscan-change-comment-generic_file_write-to-__generic_file_aio_write.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
