The patch titled vfs: remove extraneous NULL d_inode check from do_filp_open has been added to the -mm tree. Its filename is vfs-remove-extraneous-null-d_inode-check-from-do_filp_open.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: vfs: remove extraneous NULL d_inode check from do_filp_open From: Jeff Layton <jlayton@xxxxxxxxxx> We can't get to this point unless it's a valid pointer. Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx> Cc: Christoph Hellwig <hch@xxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN fs/namei.c~vfs-remove-extraneous-null-d_inode-check-from-do_filp_open fs/namei.c --- a/fs/namei.c~vfs-remove-extraneous-null-d_inode-check-from-do_filp_open +++ a/fs/namei.c @@ -1818,7 +1818,7 @@ do_last: path_to_nameidata(&path, &nd); error = -EISDIR; - if (path.dentry->d_inode && S_ISDIR(path.dentry->d_inode->i_mode)) + if (S_ISDIR(path.dentry->d_inode->i_mode)) goto exit; ok: /* _ Patches currently in -mm which might be from jlayton@xxxxxxxxxx are vfs-remove-extraneous-null-d_inode-check-from-do_filp_open.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html