The patch titled exec: setup_arg_pages() fails to return errors has been added to the -mm tree. Its filename is exec-setup_arg_pages-fails-to-return-errors.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: exec: setup_arg_pages() fails to return errors From: Anton Blanchard <anton@xxxxxxxxx> In setup_arg_pages we work hard to assign a value to ret, but on exit we always return 0. Also remove a now duplicated exit path and branch to out_unlock instead. Signed-off-by: Anton Blanchard <anton@xxxxxxxxx> Acked-by: Serge Hallyn <serue@xxxxxxxxxx> Reviewed-by: WANG Cong <xiyou.wangcong@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/exec.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff -puN fs/exec.c~exec-setup_arg_pages-fails-to-return-errors fs/exec.c --- a/fs/exec.c~exec-setup_arg_pages-fails-to-return-errors +++ a/fs/exec.c @@ -623,10 +623,8 @@ int setup_arg_pages(struct linux_binprm /* Move stack pages down in memory. */ if (stack_shift) { ret = shift_arg_pages(vma, stack_shift); - if (ret) { - up_write(&mm->mmap_sem); - return ret; - } + if (ret) + goto out_unlock; } #ifdef CONFIG_STACK_GROWSUP @@ -640,7 +638,7 @@ int setup_arg_pages(struct linux_binprm out_unlock: up_write(&mm->mmap_sem); - return 0; + return ret; } EXPORT_SYMBOL(setup_arg_pages); _ Patches currently in -mm which might be from anton@xxxxxxxxx are linux-next.patch exec-setup_arg_pages-fails-to-return-errors.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html