The patch titled scripts/checkpatch.pl: add WARN on sizeof(&foo) has been added to the -mm tree. Its filename is scripts-checkpatchpl-add-warn-on-sizeof.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: scripts/checkpatch.pl: add WARN on sizeof(&foo) From: Joe Perches <joe@xxxxxxxxxxx> sizeof(&foo) is frequently an error. Warn on its use. Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> Cc: Andy Whitcroft <apw@xxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- diff -puN scripts/checkpatch.pl~scripts-checkpatchpl-add-warn-on-sizeof scripts/checkpatch.pl --- a/scripts/checkpatch.pl~scripts-checkpatchpl-add-warn-on-sizeof +++ a/scripts/checkpatch.pl @@ -2580,6 +2580,11 @@ sub process { WARN("plain inline is preferred over $1\n" . $herecurr); } +# check for sizeof(&) + if ($line =~ /\bsizeof\s*\(\s*\&/) { + WARN("sizeof(& should be avoided\n" . $herecurr); + } + # check for new externs in .c files. if ($realfile =~ /\.c$/ && defined $stat && $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s) _ Patches currently in -mm which might be from joe@xxxxxxxxxxx are origin.patch maintainers-update-generic-uio-for-pci-devices.patch maintainers-update-tracing-section.patch maintainers-update-omap-tony-lindgren-email-name.patch maintainers-change-atm-mailing-list-to-moderated.patch maintainers-use-tab-not-spaces-after-field-types.patch maintainers-update-kernel-janitors-after-mismerge.patch maintainers-update-score-architecture-name-style-and-add-file-pattern.patch maintainers-simple-firmware-interface-update-email-style.patch maintainers-winbond-cir-integrate-p-m-lines-fixup-david-härdemans-name.patch maintainers-fix-up-peripheral-spelling.patch maintainers-update-wolfson-microelectronics.patch scripts-get_maintainerpl-add-patch-file-search-for-keywords.patch maintainers-document-new-k-entry-type.patch maintainers-add-open-firmware-flattened-device-tree-entry.patch linux-next.patch checkpatchpl-allow-80-char-lines-for-logging-functions-not-just-printk.patch dynamic_debugh-kernelh-remove-kbuild_modname-from-dynamic_pr_debug.patch kernelh-remove-initialization-of-bool-in-printk_once.patch lib-vsprintfc-add-%pu-to-print-uuid-guids.patch fs-xfs-xfs_log_recoverc-use-%pu-to-print-uuids.patch randomc-use-%pu-to-print-uuids.patch drivers-firmware-dmi_scanc-use-%pub-to-print-uuids.patch drivers-md-mdc-use-%pu-to-print-uuids.patch fs-gfs2-sysc-use-%pub-to-print-uuids.patch fs-ubifs-use-%pub-to-print-uuids.patch efih-use-%pul-to-print-uuids.patch drivers-media-video-uvc-use-%pul-to-print-uuids.patch lib-unified-uuid-guid-definition.patch gfs2-use-unified-uuid-guid-code.patch scripts-checkpatchpl-add-warn-on-sizeof.patch isicomc-use-pr_fmt-and-pr_level.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html