The patch titled signals: send_signal: use si_fromuser() to detect from_ancestor_ns has been added to the -mm tree. Its filename is signals-send_signal-use-si_fromuser-to-detect-from_ancestor_ns.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: signals: send_signal: use si_fromuser() to detect from_ancestor_ns From: Oleg Nesterov <oleg@xxxxxxxxxx> Change send_signal() to use si_fromuser(). From now SEND_SIG_NOINFO triggers the "from_ancestor_ns" check. This fixes reparent_thread()->group_send_sig_info(pdeath_signal) behaviour, before this patch send_signal() does not detect the cross-namespace case when the child of the dying parent belongs to the sub-namespace. This patch can affect the behaviour of send_sig(), kill_pgrp() and kill_pid() when the caller sends the signal to the sub-namespace with "priv == 0" but surprisingly all callers seem to use them correctly, including disassociate_ctty(on_exit). Except: drivers/staging/comedi/drivers/addi-data/*.c incorrectly use send_sig(priv => 0). But his is minor and should be fixed anyway. Reported-by: Daniel Lezcano <dlezcano@xxxxxxxxxx> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx> Cc: Roland McGrath <roland@xxxxxxxxxx> Reviewed-by: Sukadev Bhattiprolu <sukadev@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- diff -puN kernel/signal.c~signals-send_signal-use-si_fromuser-to-detect-from_ancestor_ns kernel/signal.c --- a/kernel/signal.c~signals-send_signal-use-si_fromuser-to-detect-from_ancestor_ns +++ a/kernel/signal.c @@ -928,9 +928,8 @@ static int send_signal(int sig, struct s int from_ancestor_ns = 0; #ifdef CONFIG_PID_NS - if (!is_si_special(info) && SI_FROMUSER(info) && - task_pid_nr_ns(current, task_active_pid_ns(t)) <= 0) - from_ancestor_ns = 1; + from_ancestor_ns = si_fromuser(info) && + !task_pid_nr_ns(current, task_active_pid_ns(t)); #endif return __send_signal(sig, info, t, group, from_ancestor_ns); _ Patches currently in -mm which might be from oleg@xxxxxxxxxx are linux-next.patch connector-fix-regression-introduced-by-sid-connector.patch itimers-fix-racy-writes-to-cpu_itimer-fields.patch posix-cpu-timers-optimize-and-document-timer_create-callback.patch do_wait-optimization-do-not-place-sub-threads-on-task_struct-children-list.patch signals-send_sig_noinfo-should-be-considered-as-si_fromuser.patch signals-send_signal-use-si_fromuser-to-detect-from_ancestor_ns.patch signals-cosmetic-collect_signal-use-si_user.patch signals-kill-force_sig_specific.patch utrace-core.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html