The patch titled
eeepc_laptop: properly annote eeepc_enable_camera()
has been added to the -mm tree. Its filename is
eeepc_laptop-properly-annote-eeepc_enable_camera.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: eeepc_laptop: properly annote eeepc_enable_camera()
From: Rakib Mullick <rakib.mullick@xxxxxxxxx>
Currently the annotation for function eeepc_enable_camera() is __init, and
refers to a function eeepc_hotk_add() which is non-init. Use __devinit
for both functions which is more appropriate and fixes a section mismatch
warning.
We were warned by the following warning:
LD drivers/platform/x86/built-in.o
WARNING: drivers/platform/x86/built-in.o(.text+0x12e1): Section
mismatch in reference from the function eeepc_hotk_add() to the
function .init.text:eeepc_enable_camera()
The function eeepc_hotk_add() references
the function __init eeepc_enable_camera().
This is often because eeepc_hotk_add lacks a __init
annotation or the annotation of eeepc_enable_camera is wrong.
Signed-off-by: Rakib Mullick <rakib.mullick@xxxxxxxxx>
Cc: Len Brown <lenb@xxxxxxxxxx>
Cc: Corentin Chary <corentincj@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
diff -puN drivers/platform/x86/eeepc-laptop.c~eeepc_laptop-properly-annote-eeepc_enable_camera drivers/platform/x86/eeepc-laptop.c
--- a/drivers/platform/x86/eeepc-laptop.c~eeepc_laptop-properly-annote-eeepc_enable_camera
+++ a/drivers/platform/x86/eeepc-laptop.c
@@ -350,7 +350,7 @@ static const struct rfkill_ops eeepc_rfk
.set_block = eeepc_rfkill_set,
};
-static void __init eeepc_enable_camera(void)
+static void __devinit eeepc_enable_camera(void)
{
/*
* If the following call to set_acpi() fails, it's because there's no
@@ -1189,7 +1189,7 @@ static int eeepc_input_init(struct devic
return 0;
}
-static int eeepc_hotk_add(struct acpi_device *device)
+static int __devinit eeepc_hotk_add(struct acpi_device *device)
{
struct device *dev;
int result;
_
Patches currently in -mm which might be from rakib.mullick@xxxxxxxxx are
linux-next.patch
acpi-annote-acpi_processor_add-with-__cpuinit.patch
eeepc_laptop-properly-annote-eeepc_enable_camera.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
