The patch titled spi-imx: initialize complete config struct has been added to the -mm tree. Its filename is spi-imx-initialize-complete-config-struct.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: spi-imx: initialize complete config struct From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Otherwise the config function uses random data from the stack. This didn't stick out because config is called once more in the chipselect function with correct parameters. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Acked-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> Cc: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> Cc: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/spi/spi_imx.c | 1 + 1 file changed, 1 insertion(+) diff -puN drivers/spi/spi_imx.c~spi-imx-initialize-complete-config-struct drivers/spi/spi_imx.c --- a/drivers/spi/spi_imx.c~spi-imx-initialize-complete-config-struct +++ a/drivers/spi/spi_imx.c @@ -442,6 +442,7 @@ static int spi_imx_setupxfer(struct spi_ config.bpw = t ? t->bits_per_word : spi->bits_per_word; config.speed_hz = t ? t->speed_hz : spi->max_speed_hz; config.mode = spi->mode; + config.cs = spi_imx->chipselect[spi->chip_select]; if (!config.speed_hz) config.speed_hz = spi->max_speed_hz; _ Patches currently in -mm which might be from u.kleine-koenig@xxxxxxxxxxxxxx are linux-next.patch spi-imx-rename-source-file-to-spi_imxc.patch spi-imx-update-state-correctly.patch spi-imx-fix-initial-chipselect-settings.patch spi-imx-setup-mode_bits-we-can-handle.patch spi-imx-no-need-to-assert-bits_per_word-being-initialized.patch spi-imx-initialize-complete-config-struct.patch spi-imx-strip-down-chipselect-function-to-only-drive-the-chipselect.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html