The patch titled
jsm: IRQ handlers doesn't need to have IRQ_DISABLED enabled
has been added to the -mm tree. Its filename is
jsm-irq-handlers-doesnt-need-to-have-irq_disabled-enabled.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: jsm: IRQ handlers doesn't need to have IRQ_DISABLED enabled
From: Breno Leitao <leitao@xxxxxxxxxxxxxxxxxx>
Currently jsm is showing the following message when loaded:
IRQ 432/JSM: IRQF_DISABLED is not guaranteed on shared IRQs
It's because the request_irq() is called using IRQF_DISABLED and
IRQF_SHARED. Actually there is no need to use IRQF_DISABLED in this
driver.
Signed-off-by: Breno Leitao <leitao@xxxxxxxxxxxxxxxxxx>
Cc: Greg KH <greg@xxxxxxxxx>
Cc: Scott Kilau <scottk@xxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/serial/jsm/jsm_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/serial/jsm/jsm_driver.c~jsm-irq-handlers-doesnt-need-to-have-irq_disabled-enabled drivers/serial/jsm/jsm_driver.c
--- a/drivers/serial/jsm/jsm_driver.c~jsm-irq-handlers-doesnt-need-to-have-irq_disabled-enabled
+++ a/drivers/serial/jsm/jsm_driver.c
@@ -123,7 +123,7 @@ static int __devinit jsm_probe_one(struc
}
rc = request_irq(brd->irq, brd->bd_ops->intr,
- IRQF_DISABLED|IRQF_SHARED, "JSM", brd);
+ IRQF_SHARED, "JSM", brd);
if (rc) {
printk(KERN_WARNING "Failed to hook IRQ %d\n",brd->irq);
goto out_iounmap;
_
Patches currently in -mm which might be from leitao@xxxxxxxxxxxxxxxxxx are
jsm-irq-handlers-doesnt-need-to-have-irq_disabled-enabled.patch
jsm-rewriting-a-bad-log-message.patch
icom-converting-space-to-tabs.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
