The patch titled drivers/scsi/libsas: use SAM_GOOD has been added to the -mm tree. Its filename is drivers-scsi-libsas-use-sam_good.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: drivers/scsi/libsas: use SAM_GOOD From: Julia Lawall <julia@xxxxxxx> The field stat->stat should be compared to SAM_GOOD, not SAM_STAT_GOOD, as done elsewhere in the same function. Both constants have the same value. Signed-off-by: Julia Lawall <julia@xxxxxxx> Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/scsi/libsas/sas_ata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/scsi/libsas/sas_ata.c~drivers-scsi-libsas-use-sam_good drivers/scsi/libsas/sas_ata.c --- a/drivers/scsi/libsas/sas_ata.c~drivers-scsi-libsas-use-sam_good +++ a/drivers/scsi/libsas/sas_ata.c @@ -112,7 +112,7 @@ static void sas_ata_task_done(struct sas dev->sata_dev.sstatus = resp->sstatus; dev->sata_dev.serror = resp->serror; dev->sata_dev.scontrol = resp->scontrol; - } else if (stat->stat != SAM_STAT_GOOD) { + } else if (stat->stat != SAM_GOOD) { ac = sas_to_ata_err(stat); if (ac) { SAS_DPRINTK("%s: SAS error %x\n", __func__, _ Patches currently in -mm which might be from julia@xxxxxxx are linux-next.patch drivers-md-introduce-missing-kfree.patch drivers-scsi-libsas-use-sam_good.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html