The patch titled
splice: update mtime and atime on files
has been added to the -mm tree. Its filename is
splice-update-mtime-and-atime-on-files.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: splice: update mtime and atime on files
From: Miklos Szeredi <mszeredi@xxxxxxx>
Splice should update the modification and access times on regular files
just like read and write. Not updating mtime will confuse backup tools,
etc...
This patch only adds the time updates for regular files. For pipes and
other special files that splice touches the need for updating the times is
less clear. Let's discuss and fix that separately.
Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxx>
Cc: Jens Axboe <jens.axboe@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/splice.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff -puN fs/splice.c~splice-update-mtime-and-atime-on-files fs/splice.c
--- a/fs/splice.c~splice-update-mtime-and-atime-on-files
+++ a/fs/splice.c
@@ -502,8 +502,10 @@ ssize_t generic_file_splice_read(struct
len = left;
ret = __generic_file_splice_read(in, ppos, pipe, len, flags);
- if (ret > 0)
+ if (ret > 0) {
*ppos += ret;
+ file_accessed(in);
+ }
return ret;
}
@@ -963,8 +965,10 @@ generic_file_splice_write(struct pipe_in
mutex_lock_nested(&inode->i_mutex, I_MUTEX_CHILD);
ret = file_remove_suid(out);
- if (!ret)
+ if (!ret) {
+ file_update_time(out);
ret = splice_from_pipe_feed(pipe, &sd, pipe_to_file);
+ }
mutex_unlock(&inode->i_mutex);
} while (ret > 0);
splice_from_pipe_end(pipe, &sd);
_
Patches currently in -mm which might be from mszeredi@xxxxxxx are
linux-next.patch
splice-update-mtime-and-atime-on-files.patch
vfs-fix-vfs_rename_dir-for-fs_rename_does_d_move-filesystems.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
