The patch titled
md: avoid use of broken kzalloc mempool
has been added to the -mm tree. Its filename is
md-avoid-use-of-broken-kzalloc-mempool.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: md: avoid use of broken kzalloc mempool
From: Sage Weil <sage@xxxxxxxxxxxx>
The kzalloc mempool does not re-zero items that have been used and then
returned to the pool. Manually zero the allocated multipath_bh instead.
Acked-by: Neil Brown <neilb@xxxxxxx>
Cc: <stable@xxxxxxxxxx>
Signed-off-by: Sage Weil <sage@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/md/multipath.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN drivers/md/multipath.c~md-avoid-use-of-broken-kzalloc-mempool drivers/md/multipath.c
--- a/drivers/md/multipath.c~md-avoid-use-of-broken-kzalloc-mempool
+++ a/drivers/md/multipath.c
@@ -150,6 +150,7 @@ static int multipath_make_request (struc
}
mp_bh = mempool_alloc(conf->pool, GFP_NOIO);
+ memset(mp_bh, 0, sizeof(*mp_bh));
mp_bh->master_bio = bio;
mp_bh->mddev = mddev;
@@ -493,7 +494,7 @@ static int multipath_run (mddev_t *mddev
}
mddev->degraded = conf->raid_disks - conf->working_disks;
- conf->pool = mempool_create_kzalloc_pool(NR_RESERVED_BUFS,
+ conf->pool = mempool_create_kmalloc_pool(NR_RESERVED_BUFS,
sizeof(struct multipath_bh));
if (conf->pool == NULL) {
printk(KERN_ERR
_
Patches currently in -mm which might be from sage@xxxxxxxxxxxx are
vfs-fix-vfs_rename_dir-for-fs_rename_does_d_move-filesystems.patch
md-avoid-use-of-broken-kzalloc-mempool.patch
ibmvscsi-avoid-unnecessary-use-of-kzalloc_pool.patch
mm-remove-broken-kzalloc-mempool.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
