The patch titled
generic-ipi-fix-the-race-between-generic_smp_call_function_-and-hotplug_cfd fix
has been added to the -mm tree. Its filename is
generic-ipi-fix-the-race-between-generic_smp_call_function_-and-hotplug_cfd-fix.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: generic-ipi-fix-the-race-between-generic_smp_call_function_-and-hotplug_cfd fix
From: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxx>
This patch is incomplete and thanks for Peter Zijlstra to point out
Signed-off-by: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxx>
Cc: Jens Axboe <jens.axboe@xxxxxxxxxx>
Cc: Nick Piggin <nickpiggin@xxxxxxxxxxxx>
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
kernel/smp.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff -puN kernel/smp.c~generic-ipi-fix-the-race-between-generic_smp_call_function_-and-hotplug_cfd-fix kernel/smp.c
--- a/kernel/smp.c~generic-ipi-fix-the-race-between-generic_smp_call_function_-and-hotplug_cfd-fix
+++ a/kernel/smp.c
@@ -136,7 +136,8 @@ __generic_smp_call_function_interrupt(in
if (!cpumask_test_and_clear_cpu(cpu, data->cpumask))
continue;
- data->csd.func(data->csd.info);
+ if (run_callbacks)
+ data->csd.func(data->csd.info);
refs = atomic_dec_return(&data->refs);
WARN_ON(refs < 0);
@@ -187,7 +188,8 @@ __generic_smp_call_function_single_inter
*/
data_flags = data->flags;
- data->func(data->info);
+ if (run_callbacks)
+ data->func(data->info);
/*
* Unlocked CSDs are valid through generic_exec_single():
_
Patches currently in -mm which might be from xiaoguangrong@xxxxxxxxxxxxxx are
generic-ipi-fix-hotplug_cfd.patch
generic-ipi-make-struct-call_function_data-lockless.patch
generic-ipi-make-struct-call_function_data-lockless-cleanup.patch
generic-ipi-cleanup-for-generic_smp_call_function_interrupt.patch
kernel-smpc-relocate-some-code.patch
generic-ipi-fix-the-race-between-generic_smp_call_function_-and-hotplug_cfd.patch
generic-ipi-fix-the-race-between-generic_smp_call_function_-and-hotplug_cfd-fix.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
