The patch titled drivers/video/imxfb.c: fix resource size off by 1 error has been added to the -mm tree. Its filename is drivers-video-imxfbc-fix-resource-size-off-by-1-error.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: drivers/video/imxfb.c: fix resource size off by 1 error From: Julia Lawall <julia@xxxxxxx> In the first case, the change is not semantics-preserving, but resource_size is used at the corresponding call to request_mem_region in the same function. In the second case, the change is semantics-preserving. The problem was found using the following semantic patch: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ struct resource *res; @@ - (res->end - res->start) + 1 + resource_size(res) @@ struct resource *res; @@ - res->end - res->start + BAD(resource_size(res)) // </smpl> Signed-off-by: Julia Lawall <julia@xxxxxxx> Cc: Krzysztof Benedyczak <golbi@xxxxxxxxxxxxxxxx> Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/video/imxfb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/video/imxfb.c~drivers-video-imxfbc-fix-resource-size-off-by-1-error drivers/video/imxfb.c --- a/drivers/video/imxfb.c~drivers-video-imxfbc-fix-resource-size-off-by-1-error +++ a/drivers/video/imxfb.c @@ -754,7 +754,7 @@ failed_map: failed_getclock: iounmap(fbi->regs); failed_ioremap: - release_mem_region(res->start, res->end - res->start); + release_mem_region(res->start, resource_size(res)); failed_req: kfree(info->pseudo_palette); failed_init: @@ -785,7 +785,7 @@ static int __devexit imxfb_remove(struct framebuffer_release(info); iounmap(fbi->regs); - release_mem_region(res->start, res->end - res->start + 1); + release_mem_region(res->start, resource_size(res)); clk_disable(fbi->clk); clk_put(fbi->clk); _ Patches currently in -mm which might be from julia@xxxxxxx are origin.patch linux-next.patch drivers-video-imxfbc-fix-resource-size-off-by-1-error.patch edac-fix-resource-size-calculation.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html