The patch titled
mx3fb: initialize mm_lock in init_fb_chan()
has been added to the -mm tree. Its filename is
mx3fb-initialize-mm_lock-in-init_fb_chan.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: mx3fb: initialize mm_lock in init_fb_chan()
From: Daniel Mack <daniel@xxxxxxxx>
In 537a1bf05 ("fbdev: add mutex for fb_mmap locking"), a per-fbinfo mutex
was added and framebuffer drivers were adopted accordingly. This new lock
is currently initialized in register_framebuffer().
The mx3fb driver takes this lock in mx3fb_map_video_memory() _before_
register_framebuffer() is called and hence crashes the system very early.
To fix this, initialize this lock init_fb_chan() in the mx3fb driver.
Signed-off-by: Daniel Mack <daniel@xxxxxxxx>
Acked-by: Krzysztof Helt <krzysztof.h1@xxxxx>
Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
Cc: Rafael J. Wysocki <rjw@xxxxxxx>
Cc: <stable@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/video/mx3fb.c | 1 +
1 file changed, 1 insertion(+)
diff -puN drivers/video/mx3fb.c~mx3fb-initialize-mm_lock-in-init_fb_chan drivers/video/mx3fb.c
--- a/drivers/video/mx3fb.c~mx3fb-initialize-mm_lock-in-init_fb_chan
+++ a/drivers/video/mx3fb.c
@@ -1362,6 +1362,7 @@ static int init_fb_chan(struct mx3fb_dat
mx3fbi->mx3fb = mx3fb;
mx3fbi->blank = FB_BLANK_NORMAL;
+ mutex_init(&fbi->mm_lock);
init_completion(&mx3fbi->flip_cmpl);
disable_irq(ichan->eof_irq);
dev_dbg(mx3fb->dev, "disabling irq %d\n", ichan->eof_irq);
_
Patches currently in -mm which might be from daniel@xxxxxxxx are
mx3fb-initialize-mm_lock-in-init_fb_chan.patch
lis3-fix-typo.patch
lis3-add-free-fall-wakeup-function-via-platform_data.patch
lis3-add-power-management-functions.patch
lis3-add-power-management-functions-fix.patch
lis3_spi-code-cleanups.patch
rtc-add-driver-for-mxcs-internal-rtc-module.patch
rtc-add-driver-for-mxcs-internal-rtc-module-fix.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
