The patch titled
vmscan: don't attempt to reclaim anon page in lumpy reclaim when no swap space is available
has been added to the -mm tree. Its filename is
vmscan-dont-attempt-to-reclaim-anon-page-in-lumpy-reclaim-when-no-swap-space-is-available.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: vmscan: don't attempt to reclaim anon page in lumpy reclaim when no swap space is available
From: Minchan Kim <minchan.kim@xxxxxxxxx>
VM already avoids attempting to reclaim anon pages in various places, But
it doesn't avoid it for lumpy reclaim.
It shuffles lru list unnecessary so that it is pointless.
__isolate_lru_page is called on slow path so that some condition check
could be not critical about performance.
Signed-off-by: Minchan Kim <minchan.kim@xxxxxxxxx>
Cc: Mel Gorman <mel@xxxxxxxxx>
Cc: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
Cc: Rik van Riel <riel@xxxxxxxxxx>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/vmscan.c | 6 ++++++
1 file changed, 6 insertions(+)
diff -puN mm/vmscan.c~vmscan-dont-attempt-to-reclaim-anon-page-in-lumpy-reclaim-when-no-swap-space-is-available mm/vmscan.c
--- a/mm/vmscan.c~vmscan-dont-attempt-to-reclaim-anon-page-in-lumpy-reclaim-when-no-swap-space-is-available
+++ a/mm/vmscan.c
@@ -823,7 +823,13 @@ int __isolate_lru_page(struct page *page
* When this function is being called for lumpy reclaim, we
* initially look into all LRU pages, active, inactive and
* unevictable; only give shrink_page_list evictable pages.
+ *
+ * If we don't have enough swap space, reclaiming of anon page
+ * which don't already have a swap slot is pointless.
*/
+ if (nr_swap_pages <= 0 && (PageAnon(page) && !PageSwapCache(page)))
+ return ret;
+
if (PageUnevictable(page))
return ret;
_
Patches currently in -mm which might be from minchan.kim@xxxxxxxxx are
linux-next.patch
vmscan-dont-attempt-to-reclaim-anon-page-in-lumpy-reclaim-when-no-swap-space-is-available.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
