The patch titled gpio: pl061: fix probe error handling code has been added to the -mm tree. Its filename is gpio-pl061-fix-probe-error-handling-code.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: gpio: pl061: fix probe error handling code From: Baruch Siach <baruch@xxxxxxxxxx> Note that IRQ has not been initialized when kmalloc() fails. Also, use DECLARE_BITMAP() to make the code clearer. Signed-off-by: Baruch Siach <baruch@xxxxxxxxxx> Cc: David Brownell <david-b@xxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/gpio/pl061.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -puN drivers/gpio/pl061.c~gpio-pl061-fix-probe-error-handling-code drivers/gpio/pl061.c --- a/drivers/gpio/pl061.c~gpio-pl061-fix-probe-error-handling-code +++ a/drivers/gpio/pl061.c @@ -221,7 +221,7 @@ static int __init pl061_probe(struct amb struct pl061_gpio *chip; struct list_head *chip_list; int ret, irq, i; - static unsigned long init_irq[BITS_TO_LONGS(NR_IRQS)]; + static DECLARE_BITMAP(init_irq, NR_IRQS); pdata = dev->dev.platform_data; if (pdata == NULL) @@ -280,6 +280,7 @@ static int __init pl061_probe(struct amb if (!test_and_set_bit(irq, init_irq)) { /* list initialized? */ chip_list = kmalloc(sizeof(*chip_list), GFP_KERNEL); if (chip_list == NULL) { + clear_bit(irq, init_irq); ret = -ENOMEM; goto iounmap; } _ Patches currently in -mm which might be from baruch@xxxxxxxxxx are origin.patch linux-next.patch gpio-pl061-fix-probe-error-handling-code.patch gpio-pl061-fix-irq-handling-for-gpios-=-pl061_gpio_nr.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html