The patch titled
wireless: remove redundant tests on unsigned
has been added to the -mm tree. Its filename is
wireless-remove-redundant-tests-on-unsigned.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: wireless: remove redundant tests on unsigned
From: Roel Kluin <roel.kluin@xxxxxxxxx>
bufsize and remainder are unsigned. When negative they are wrapped and
caught by the other test.
Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
Acked-by: Pavel Roskin <proski@xxxxxxx> [hermes.c]
Cc: "John W. Linville" <linville@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/net/wireless/orinoco/hermes.c | 2 +-
drivers/net/wireless/rtl818x/rtl8180_dev.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff -puN drivers/net/wireless/orinoco/hermes.c~wireless-remove-redundant-tests-on-unsigned drivers/net/wireless/orinoco/hermes.c
--- a/drivers/net/wireless/orinoco/hermes.c~wireless-remove-redundant-tests-on-unsigned
+++ a/drivers/net/wireless/orinoco/hermes.c
@@ -469,7 +469,7 @@ int hermes_read_ltv(hermes_t *hw, int ba
u16 rlength, rtype;
unsigned nwords;
- if ((bufsize < 0) || (bufsize % 2))
+ if (bufsize % 2)
return -EINVAL;
err = hermes_docmd_wait(hw, HERMES_CMD_ACCESS, rid, NULL);
diff -puN drivers/net/wireless/rtl818x/rtl8180_dev.c~wireless-remove-redundant-tests-on-unsigned drivers/net/wireless/rtl818x/rtl8180_dev.c
--- a/drivers/net/wireless/rtl818x/rtl8180_dev.c~wireless-remove-redundant-tests-on-unsigned
+++ a/drivers/net/wireless/rtl818x/rtl8180_dev.c
@@ -280,7 +280,7 @@ static int rtl8180_tx(struct ieee80211_h
(ieee80211_get_tx_rate(dev, info)->bitrate * 2) / 10);
remainder = (16 * (skb->len + 4)) %
((ieee80211_get_tx_rate(dev, info)->bitrate * 2) / 10);
- if (remainder > 0 && remainder <= 6)
+ if (remainder <= 6)
plcp_len |= 1 << 15;
}
_
Patches currently in -mm which might be from roel.kluin@xxxxxxxxx are
linux-next.patch
s3c-fix-check-of-index-into-s3c_gpios.patch
powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned.patch
ext4-remove-redundant-test-on-unsigned.patch
wireless-remove-redundant-tests-on-unsigned.patch
frv-duplicate-output_buffer-of-e03.patch
frv-duplicate-output_buffer-of-e03-checkpatch-fixes.patch
m68k-count-can-reach-51-not-50.patch
m68k-cnt-reaches-1-not-0.patch
platinumfb-misplaced-parenthesis.patch
adfs-remove-redundant-test-on-unsigned.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
