[to-be-updated] elf-reduce-default-max_map_count-to-be-safe-value.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     elf: reduce default MAX_MAP_COUNT to be safe value
has been removed from the -mm tree.  Its filename was
     elf-reduce-default-max_map_count-to-be-safe-value.patch

This patch was dropped because an updated version will be merged

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: elf: reduce default MAX_MAP_COUNT to be safe value
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>

With ELF, at generating coredump, some more headers other than used vmas
are added.  When, maxp_map_count == 65536, a core generated by following
kinds of code can be unreadable because the number of ELF's program header
is written in 16bit in Ehdr (please see elf.h) and the number overflows.

==
	... = mmap(); (munmap, mprotect, etc...)
	if (failed)
		abort();
==

This can be happen in mmap/munmap/mprotect/etc...which calls split_vma().

I think 65536 is not safe as _default_ because core-dump can be corrupted
when we need to look into coredump.  This reduce it to 65500 for avoiding
unexpected corrupted core.  (I confirmed 65530 can work well with my tiny
program.)

Anyway, max_map_count can be enlarged by sysctl if a user is brave..

Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
Cc: Jakub Jelinek <jakub@xxxxxxxxxx>
Cc: Roland McGrath <roland@xxxxxxxxxx>
Cc: Hugh Dickins <hugh.dickins@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 include/linux/sched.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN include/linux/sched.h~elf-reduce-default-max_map_count-to-be-safe-value include/linux/sched.h
--- a/include/linux/sched.h~elf-reduce-default-max_map_count-to-be-safe-value
+++ a/include/linux/sched.h
@@ -351,7 +351,7 @@ struct nsproxy;
 struct user_namespace;
 
 /* Maximum number of active map areas.. This is a random (large) number */
-#define DEFAULT_MAX_MAP_COUNT	65536
+#define DEFAULT_MAX_MAP_COUNT	65500
 
 extern int sysctl_max_map_count;
 
_

Patches currently in -mm which might be from kamezawa.hiroyu@xxxxxxxxxxxxxx are

origin.patch
elf-reduce-default-max_map_count-to-be-safe-value.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux