[folded] fbdev-s1d13xxxfb-add-accelerated-bitblt-functions-checkpatch-fixes.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     fbdev-s1d13xxxfb-add-accelerated-bitblt-functions-checkpatch-fixes
has been removed from the -mm tree.  Its filename was
     fbdev-s1d13xxxfb-add-accelerated-bitblt-functions-checkpatch-fixes.patch

This patch was dropped because it was folded into fbdev-s1d13xxxfb-add-accelerated-bitblt-functions.patch

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: fbdev-s1d13xxxfb-add-accelerated-bitblt-functions-checkpatch-fixes
From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

WARNING: line over 80 characters
#87: FILE: drivers/video/s1d13xxxfb.c:55:
+#define dbg_blit(fmt, args...) do {printk(KERN_INFO BLIT fmt, ## args); } while(0)

ERROR: space required before the open parenthesis '('
#87: FILE: drivers/video/s1d13xxxfb.c:55:
+#define dbg_blit(fmt, args...) do {printk(KERN_INFO BLIT fmt, ## args); } while(0)

WARNING: line over 80 characters
#283: FILE: drivers/video/s1d13xxxfb.c:522:
+	s1d13xxxfb_writereg(info->par, S1DREG_BBLT_SRC_START1, (src >> 8) & 0x00ff);

WARNING: line over 80 characters
#284: FILE: drivers/video/s1d13xxxfb.c:523:
+	s1d13xxxfb_writereg(info->par, S1DREG_BBLT_SRC_START2, (src >> 16) & 0x00ff);

WARNING: line over 80 characters
#288: FILE: drivers/video/s1d13xxxfb.c:527:
+	s1d13xxxfb_writereg(info->par, S1DREG_BBLT_DST_START1, (dst >> 8) & 0x00ff);

WARNING: line over 80 characters
#289: FILE: drivers/video/s1d13xxxfb.c:528:
+	s1d13xxxfb_writereg(info->par, S1DREG_BBLT_DST_START2, (dst >> 16) & 0x00ff);

WARNING: line over 80 characters
#295: FILE: drivers/video/s1d13xxxfb.c:534:
+	s1d13xxxfb_writereg(info->par, S1DREG_BBLT_HEIGHT0, (height & 0xff) - 1);

WARNING: line over 80 characters
#314: FILE: drivers/video/s1d13xxxfb.c:553:
+	s1d13xxxfb_writereg(info->par, S1DREG_BBLT_MEM_OFF0, (stride >> 1) & 0xff);

WARNING: line over 80 characters
#321: FILE: drivers/video/s1d13xxxfb.c:560:
+	dbg_blit("(copyarea) bpp=%d=0x0%d, mem_offset1=%d, mem_offset2=%d\n", bpp, (bpp >> 1),

WARNING: line over 80 characters
#345: FILE: drivers/video/s1d13xxxfb.c:584:
+s1d13xxxfb_bitblt_solidfill(struct fb_info *info, const struct fb_fillrect *rect)

WARNING: line over 80 characters
#372: FILE: drivers/video/s1d13xxxfb.c:611:
+	s1d13xxxfb_writereg(info->par, S1DREG_BBLT_DST_START1, ((dest >> 8) & 0x00ff));

WARNING: line over 80 characters
#373: FILE: drivers/video/s1d13xxxfb.c:612:
+	s1d13xxxfb_writereg(info->par, S1DREG_BBLT_DST_START2, ((dest >> 16) & 0x00ff));

WARNING: line over 80 characters
#376: FILE: drivers/video/s1d13xxxfb.c:615:
+	s1d13xxxfb_writereg(info->par, S1DREG_BBLT_WIDTH0, ((rect->width) & 0x00ff) - 1);

WARNING: line over 80 characters
#380: FILE: drivers/video/s1d13xxxfb.c:619:
+	s1d13xxxfb_writereg(info->par, S1DREG_BBLT_HEIGHT0, ((rect->height) & 0x00ff) - 1);

WARNING: line over 80 characters
#381: FILE: drivers/video/s1d13xxxfb.c:620:
+	s1d13xxxfb_writereg(info->par, S1DREG_BBLT_HEIGHT1, (rect->height >> 8));

WARNING: line over 80 characters
#387: FILE: drivers/video/s1d13xxxfb.c:626:
+		dbg_blit("(solidfill) pseudo_palette[%d] = %d\n", rect->color, fg);

WARNING: line over 80 characters
#404: FILE: drivers/video/s1d13xxxfb.c:643:
+	s1d13xxxfb_writereg(info->par, S1DREG_BBLT_CTL1, (info->var.bits_per_pixel >> 4));

WARNING: line over 80 characters
#407: FILE: drivers/video/s1d13xxxfb.c:646:
+	s1d13xxxfb_writereg(info->par, S1DREG_BBLT_MEM_OFF0, (screen_stride >> 1) & 0x00ff);

WARNING: line over 80 characters
#408: FILE: drivers/video/s1d13xxxfb.c:647:
+	s1d13xxxfb_writereg(info->par, S1DREG_BBLT_MEM_OFF1, (screen_stride >> 9));

WARNING: line over 80 characters
#458: FILE: drivers/video/s1d13xxxfb.c:922:
+	info->fix.mmio_len = pdev->resource[1].end - pdev->resource[1].start + 1;

WARNING: line over 80 characters
#461: FILE: drivers/video/s1d13xxxfb.c:924:
+	info->fix.smem_len = pdev->resource[0].end - pdev->resource[0].start + 1;

ERROR: switch and case should be at the same indent
#471: FILE: drivers/video/s1d13xxxfb.c:933:
+	switch(prod_id) {
+	    case S1D13506_PROD_ID : /* activate acceleration */

ERROR: space required before the open parenthesis '('
#471: FILE: drivers/video/s1d13xxxfb.c:933:
+	switch(prod_id) {

ERROR: space prohibited before that ':' (ctx:WxW)
#472: FILE: drivers/video/s1d13xxxfb.c:934:
+	    case S1D13506_PROD_ID : /* activate acceleration */
 	                          ^

ERROR: space prohibited before that ':' (ctx:WxE)
#478: FILE: drivers/video/s1d13xxxfb.c:940:
+	    default :
 	            ^

total: 5 errors, 20 warnings, 448 lines checked

./patches/fbdev-s1d13xxxfb-add-accelerated-bitblt-functions.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Kristoffer Ericson <kristoffer.ericson@xxxxxxxxx>
Cc: Krzysztof Helt <krzysztof.h1@xxxxxxxxx>
Cc: Russell King <rmk@xxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 drivers/video/s1d13xxxfb.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff -puN drivers/video/s1d13xxxfb.c~fbdev-s1d13xxxfb-add-accelerated-bitblt-functions-checkpatch-fixes drivers/video/s1d13xxxfb.c
--- a/drivers/video/s1d13xxxfb.c~fbdev-s1d13xxxfb-add-accelerated-bitblt-functions-checkpatch-fixes
+++ a/drivers/video/s1d13xxxfb.c
@@ -52,7 +52,7 @@
  * set this to enable debugging on 2D acceleration
  */
 #if 0
-#define dbg_blit(fmt, args...) do {printk(KERN_INFO BLIT fmt, ## args); } while(0)
+#define dbg_blit(fmt, args...) do { printk(KERN_INFO BLIT fmt, ## args); } while (0)
 #else
 #define dbg_blit(fmt, args...) do { } while (0)
 #endif
@@ -931,13 +931,13 @@ s1d13xxxfb_probe(struct platform_device 
 	info->fbops = &s1d13xxxfb_fbops;
 
 	switch(prod_id) {
-	    case S1D13506_PROD_ID : /* activate acceleration */
+	case S1D13506_PROD_ID:	/* activate acceleration */
 		s1d13xxxfb_fbops.fb_fillrect = s1d13xxxfb_bitblt_solidfill;
 		s1d13xxxfb_fbops.fb_copyarea = s1d13xxxfb_bitblt_copyarea;
 		info->flags = FBINFO_DEFAULT | FBINFO_HWACCEL_YPAN |
 			FBINFO_HWACCEL_FILLRECT | FBINFO_HWACCEL_COPYAREA;
 		break;
-	    default :
+	default:
 		break;
 	}
 
_

Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are

origin.patch
firmware_map-fix-hang-with-x86-32bit.patch
mm-consolidate-init_mm-definition.patch
readahead-record-mmap-read-around-states-in-file_ra_state.patch
mm-clean-up-get_user_pages_fast-documentation.patch
page-allocator-do-not-sanity-check-order-in-the-fast-path.patch
page-allocator-calculate-the-preferred-zone-for-allocation-only-once.patch
page-allocator-remove-a-branch-by-assuming-__gfp_high-==-alloc_high.patch
pagemap-add-page-types-tool.patch
videobuf-dma-contig-zero-copy-userptr-support-v3.patch
page-allocator-warn-if-__gfp_nofail-is-used-for-a-large-allocation.patch
mm-pm-freezer-disable-oom-killer-when-tasks-are-frozen.patch
page-allocator-clean-up-functions-related-to-pages_min.patch
page-allocator-add-inactive-ratio-calculation-function-of-each-zone.patch
mm-add-a-gfp-translate-script-to-help-understand-page-allocation-failure-reports.patch
vmscan-count-the-number-of-times-zone_reclaim-scans-and-fails.patch
headers-move-module_bug_finalize-module_bug_cleanup-definitions-into-moduleh.patch
remove-put_cpu_no_resched.patch
rb_tree-reorganize-code-in-rb_erase-for-additional-changes.patch
radeon-p2g2clk_always_onb-tested-twice-should-2nd-be-p2g2clk_dac_always_onb.patch
fbdev-add-support-for-handoff-from-firmware-to-hw-framebuffers.patch
fbdev-s1d13xxxfb-add-accelerated-bitblt-functions.patch
fbdev-s1d13xxxfb-add-accelerated-bitblt-functions-checkpatch-fixes.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux