The patch titled fbdev: *bfin*: drop unnecessary calls to memset has been added to the -mm tree. Its filename is fbdev-bfin-drop-unnecessary-calls-to-memset.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: fbdev: *bfin*: drop unnecessary calls to memset From: Vivek Kutal <vivek.kutal@xxxxxxxxxx> The dma_alloc_* functions sets the memory to 0 before returning so there is no need to call memset after the allocation. Also no point in clearing the memory when disabling the buffer. Signed-off-by: Vivek Kutal <vivek.kutal@xxxxxxxxxx> Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx> Cc: Krzysztof Helt <krzysztof.h1@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/video/bf54x-lq043fb.c | 3 --- drivers/video/bfin-t350mcqb-fb.c | 3 --- 2 files changed, 6 deletions(-) diff -puN drivers/video/bf54x-lq043fb.c~fbdev-bfin-drop-unnecessary-calls-to-memset drivers/video/bf54x-lq043fb.c --- a/drivers/video/bf54x-lq043fb.c~fbdev-bfin-drop-unnecessary-calls-to-memset +++ a/drivers/video/bf54x-lq043fb.c @@ -323,7 +323,6 @@ static int bfin_bf54x_fb_release(struct bfin_write_EPPI0_CONTROL(0); SSYNC(); disable_dma(CH_EPPI0); - memset(fbi->fb_buffer, 0, info->fix.smem_len); } spin_unlock(&fbi->lock); @@ -626,8 +625,6 @@ static int __init bfin_bf54x_probe(struc goto out3; } - memset(info->fb_buffer, 0, fbinfo->fix.smem_len); - fbinfo->screen_base = (void *)info->fb_buffer; fbinfo->fix.smem_start = (int)info->fb_buffer; diff -puN drivers/video/bfin-t350mcqb-fb.c~fbdev-bfin-drop-unnecessary-calls-to-memset drivers/video/bfin-t350mcqb-fb.c --- a/drivers/video/bfin-t350mcqb-fb.c~fbdev-bfin-drop-unnecessary-calls-to-memset +++ a/drivers/video/bfin-t350mcqb-fb.c @@ -242,7 +242,6 @@ static int bfin_t350mcqb_fb_release(stru SSYNC(); disable_dma(CH_PPI); bfin_t350mcqb_stop_timers(); - memset(fbi->fb_buffer, 0, info->fix.smem_len); } spin_unlock(&fbi->lock); @@ -527,8 +526,6 @@ static int __devinit bfin_t350mcqb_probe goto out3; } - memset(info->fb_buffer, 0, fbinfo->fix.smem_len); - fbinfo->screen_base = (void *)info->fb_buffer + ACTIVE_VIDEO_MEM_OFFSET; fbinfo->fix.smem_start = (int)info->fb_buffer + ACTIVE_VIDEO_MEM_OFFSET; _ Patches currently in -mm which might be from vivek.kutal@xxxxxxxxxx are fbdev-bfin-drop-unnecessary-calls-to-memset.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html