[alternative-merged] clocksource-disallow-setting-jiffies-as-the-clocksource.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     clocksource: disallow setting jiffies as the clocksource
has been removed from the -mm tree.  Its filename was
     clocksource-disallow-setting-jiffies-as-the-clocksource.patch

This patch was dropped because an alternative patch was merged

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: clocksource: disallow setting jiffies as the clocksource
From: Luming Yu <luming.yu@xxxxxxxxx>

As reported in https://bugzilla.redhat.com/show_bug.cgi?id=496028,

	echo jiffies > clocksource0/current_clocksource

makes the system crash.

I reproduced the problem with upstream kernel.  The root cause is that
jiffies is just a variable in memory, it relies on other clock source to
tick, and it never ticks on itself.

Signed-off-by: Yu Luming <luming.yu@xxxxxxxxx>
Cc: john stultz <johnstul@xxxxxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 kernel/time/clocksource.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff -puN kernel/time/clocksource.c~clocksource-disallow-setting-jiffies-as-the-clocksource kernel/time/clocksource.c
--- a/kernel/time/clocksource.c~clocksource-disallow-setting-jiffies-as-the-clocksource
+++ a/kernel/time/clocksource.c
@@ -504,8 +504,9 @@ static ssize_t sysfs_override_clocksourc
 		/* try to select it: */
 		list_for_each_entry(cs, &clocksource_list, list) {
 			if (strlen(cs->name) == len &&
-			    !strcmp(cs->name, override_name))
-				ovr = cs;
+			    !strcmp(cs->name, override_name) &&
+				cs != &clocksource_jiffies)
+					ovr = cs;
 		}
 	}
 
_

Patches currently in -mm which might be from luming.yu@xxxxxxxxx are

linux-next.patch
clocksource-disallow-setting-jiffies-as-the-clocksource.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux