The patch titled ima: return proper error value on failure of dentry_open() has been added to the -mm tree. Its filename is ima-return-proper-error-value-on-failure-of-dentry_open.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: ima: return proper error value on failure of dentry_open() From: vibi sreenivasan <vibi_sreenivasan@xxxxxxx> dentry_open can return error value on error. Check that value before calling fput & return proper error value Signed-off-by: vibi sreenivasan <vibi_sreenivasan@xxxxxxx> Cc: Mimi Zohar <zohar@xxxxxxxxxx> Cc: Serge Hallyn <serue@xxxxxxxxxx> Cc: Reiner Sailer <sailer@xxxxxxxxxxxxxx> Cc: James Morris <jmorris@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- security/integrity/ima/ima_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN security/integrity/ima/ima_main.c~ima-return-proper-error-value-on-failure-of-dentry_open security/integrity/ima/ima_main.c --- a/security/integrity/ima/ima_main.c~ima-return-proper-error-value-on-failure-of-dentry_open +++ a/security/integrity/ima/ima_main.c @@ -198,10 +198,10 @@ int ima_path_check(struct path *path, in } out: mutex_unlock(&iint->mutex); - if (file) + if (IS_ERR(file)) fput(file); kref_put(&iint->refcount, iint_free); - return 0; + return rc; } EXPORT_SYMBOL_GPL(ima_path_check); _ Patches currently in -mm which might be from vibi_sreenivasan@xxxxxxx are ima-return-proper-error-value-on-failure-of-dentry_open.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html