The patch titled scripts/get_maintainer.pl: support both "P:/M:" and integrated "M:" lines has been added to the -mm tree. Its filename is scripts-get_maintainerpl-support-both-p-m-and-integrated-m-lines.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: scripts/get_maintainer.pl: support both "P:/M:" and integrated "M:" lines From: Joe Perches <joe@xxxxxxxxxxx> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- scripts/get_maintainer.pl | 30 ++++++++++++++++++++++-------- 1 file changed, 22 insertions(+), 8 deletions(-) diff -puN scripts/get_maintainer.pl~scripts-get_maintainerpl-support-both-p-m-and-integrated-m-lines scripts/get_maintainer.pl --- a/scripts/get_maintainer.pl~scripts-get_maintainerpl-support-both-p-m-and-integrated-m-lines +++ a/scripts/get_maintainer.pl @@ -55,7 +55,7 @@ foreach my $chief (@penguin_chief) { } my $penguin_chiefs = "\(" . join("|",@penguin_chief_names) . "\)"; -# rfc822 - preloaded methods go here. +# rfc822 email address - preloaded methods go here. my $rfc822_lwsp = "(?:(?:\\r\\n)?[ \\t])"; my $rfc822_char = '[\\000-\\177]'; @@ -396,7 +396,19 @@ sub add_categories { } } } elsif ($ptype eq "M") { - if ($email_maintainer) { + my $p_used = 0; + if ($index >= 0) { + my $tv = $typevalue[$index - 1]; + if ($tv =~ m/^(\C):\s*(.*)/) { + if ($1 eq "P") { + if ($email_usename) { + push_email_address(format_email($2, $pvalue)); + $p_used = 1; + } + } + } + } + if (!$p_used) { push_email_addresses($pvalue); } } elsif ($ptype eq "T") { @@ -436,13 +448,16 @@ sub push_email_addresses { my @address_list = (); - if (@address_list = rfc822_validlist($address)) { + if (rfc822_valid($address)) { + push_email_address($address); + } elsif (@address_list = rfc822_validlist($address)) { my $array_count = shift(@address_list); while (my $entry = shift(@address_list)) { push_email_address($entry); } + } else { + warn("Invalid MAINTAINERS address: '" . $address . "'\n"); } - } sub which { @@ -471,9 +486,8 @@ sub recent_git_signoffs { return; } if (!(-d ".git")) { - warn("$P: .git repository not found.\n"); - warn("Use a .git repository for better results.\n"); - warn("ie: git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git\n"); + warn("$P: .git directory not found. Use a git repository for better results.\n"); + warn("$P: perhaps 'git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git'\n"); return; } @@ -632,7 +646,7 @@ sub rfc822_validlist ($) { my @r; if ($s =~ m/^(?:$rfc822re)?(?:,(?:$rfc822re)?)*$/so && $s =~ m/^$rfc822_char*$/) { - while($s =~ m/(?:^|,$rfc822_lwsp*)($rfc822re)/gos) { + while ($s =~ m/(?:^|,$rfc822_lwsp*)($rfc822re)/gos) { push @r, $1; } return wantarray ? (scalar(@r), @r) : 1; _ Patches currently in -mm which might be from joe@xxxxxxxxxxx are maintainers-pair-edac-e752x-p-and-m-entries.patch linux-next.patch scripts-get_maintainerpl-output-first-field-only-in-mailing-lists-and-after-maintainers.patch scripts-get_maintainerpl-better-fix-for-subscriber-only-mailing-lists.patch scripts-get_maintainerpl-improve-git-chief-penquins-linus-torvalds-filtering.patch scripts-get_maintainerpl-warn-on-missing-git-or-git-repository.patch scripts-get_maintainerpl-support-m-lines-with-names-and-multiple-entries-per-m-line.patch scripts-get_maintainerpl-better-email-name-quoting.patch scripts-get_maintainerpl-support-both-p-m-and-integrated-m-lines.patch scripts-get_maintainerpl-dont-print-maintainers-when-not-requested.patch scripts-get_maintainerpl-allow-8-bit-characters-in-email-addresses.patch scripts-get_maintainerpl-change-die-to-warn-when-command-line-file-is-not-a-patch.patch maintainers-swap-mismarked-ecrypt-fs-m-and-p-entries.patch maintainers-add-file-patterns-to-the-rest.patch maintainers-update-m32r-file-patterns-after-rename.patch maintainers-mark-alsa-lists-as-moderated.patch maintainers-remove-l-linux-kernel-vgerkernelorg-from-all-but-the-rest.patch maintainers-mention-scripts-get_maintainerpl-in-the-preface.patch maintainers-add-file-pattern-to-cisco-fcoe-hba-driver.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html