The patch titled
slow-work: delete timers properly
has been added to the -mm tree. Its filename is
slow-work-delete-timers-properly.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: slow-work: delete timers properly
From: Jonathan Corbet <corbet@xxxxxxx>
Slow-work deletes its timer as soon as the first user unregisters, even
though other users could be active. At the same time, it never seems to
delete slow_work_oom_timer. Arrange for both to happen in the shutdown
path.
Signed-off-by: Jonathan Corbet <corbet@xxxxxxx>
Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
kernel/slow-work.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN kernel/slow-work.c~slow-work-delete-timers-properly kernel/slow-work.c
--- a/kernel/slow-work.c~slow-work-delete-timers-properly
+++ a/kernel/slow-work.c
@@ -609,14 +609,14 @@ void slow_work_unregister_user(void)
if (slow_work_user_count == 0) {
printk(KERN_NOTICE "Slow work thread pool: Shutting down\n");
slow_work_threads_should_exit = true;
+ del_timer_sync(&slow_work_cull_timer);
+ del_timer_sync(&slow_work_oom_timer);
wake_up_all(&slow_work_thread_wq);
wait_for_completion(&slow_work_last_thread_exited);
printk(KERN_NOTICE "Slow work thread pool:"
" Shut down complete\n");
}
- del_timer_sync(&slow_work_cull_timer);
-
mutex_unlock(&slow_work_user_lock);
}
EXPORT_SYMBOL(slow_work_unregister_user);
_
Patches currently in -mm which might be from corbet@xxxxxxx are
linux-next.patch
doc-add-documentation-for-debugfs.patch
slow-work-delete-timers-properly.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
