The patch titled
mm: pass correct mm when growing stack
has been added to the -mm tree. Its filename is
mm-pass-correct-mm-when-growing-stack.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: mm: pass correct mm when growing stack
From: Hugh Dickins <hugh@xxxxxxxxxxx>
Tetsuo Handa reports seeing the WARN_ON(current->mm == NULL) in
security_vm_enough_memory(), when do_execve() is touching the target mm's
stack, to set up its args and environment.
Yes, a UMH_NO_WAIT or UMH_WAIT_PROC call_usermodehelper() spawns an
mm-less kernel thread to do the exec. And in any case, that
vm_enough_memory check when growing stack ought to be done on the target
mm, not on the execer's mm (though apart from the warning, it only makes a
slight tweak to OVERCOMMIT_NEVER behaviour).
Reported-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Hugh Dickins <hugh@xxxxxxxxxxx>
Cc: <stable@xxxxxxxxxx> [2.6.28.x, 2.6.29.x]
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/mmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN mm/mmap.c~mm-pass-correct-mm-when-growing-stack mm/mmap.c
--- a/mm/mmap.c~mm-pass-correct-mm-when-growing-stack
+++ a/mm/mmap.c
@@ -1575,7 +1575,7 @@ static int acct_stack_growth(struct vm_a
* Overcommit.. This must be the final test, as it will
* update security statistics.
*/
- if (security_vm_enough_memory(grow))
+ if (security_vm_enough_memory_mm(mm, grow))
return -ENOMEM;
/* Ok, everything looks good - let it rip */
_
Patches currently in -mm which might be from hugh@xxxxxxxxxxx are
origin.patch
clocksource-pass-clocksource-to-read-callback.patch
revert-kobject-dont-block-for-each-kobject_uevent.patch
mm-pass-correct-mm-when-growing-stack.patch
mm-disable-preemption-in-apply_to_pte_range.patch
getrusage-fill-ru_maxrss-value.patch
prio_tree-debugging-patch.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
