The patch titled
radeonfb: fix: backlight shutoff flashes momentarily
has been added to the -mm tree. Its filename is
fix-radeon-backlight-shutoff-flashes-momentarily.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: radeonfb: fix: backlight shutoff flashes momentarily
From: "Robert T. Drury" <rtdrury@xxxxxxxxxxxxx>
Addresses http://bugzilla.kernel.org/show_bug.cgi?id=12845
Aluminum powerbook G4 with radeon.
The backlight momentarily flashes brightly when turning off. If the
backlight is originally dim, the flash is more noticeable. This momentary
flash is stressful on the power circuit.
The first OUTREG to LVDS_GEN_CNTL causes the flashing problem. To fix,
remove the first manipulation of lvds_gen_cntl above it.
Second manipulation of lvds_gen_cntl does nothing (level always zero).
The first manipulation was needed so the display would not be garbled
after turning the backlight back on, but at least on my powerbook, the
garbling seems to go away when the udelay is 1000.
Signed-off-by: Robert Drury <rtdrury@xxxxxxxxxxxxx>
Cc: Krzysztof Helt <krzysztof.h1@xxxxxxxxx>
Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/video/aty/radeon_backlight.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff -puN drivers/video/aty/radeon_backlight.c~fix-radeon-backlight-shutoff-flashes-momentarily drivers/video/aty/radeon_backlight.c
--- a/drivers/video/aty/radeon_backlight.c~fix-radeon-backlight-shutoff-flashes-momentarily
+++ a/drivers/video/aty/radeon_backlight.c
@@ -101,12 +101,9 @@ static int radeon_bl_update_status(struc
tmpPixclksCntl = INPLL(PIXCLKS_CNTL);
if (rinfo->is_mobility || rinfo->is_IGP)
OUTPLLP(PIXCLKS_CNTL, 0, ~PIXCLK_LVDS_ALWAYS_ONb);
- lvds_gen_cntl &= ~(LVDS_BL_MOD_LEVEL_MASK | LVDS_BL_MOD_EN);
- lvds_gen_cntl |= (radeon_bl_get_level_brightness(pdata, 0) <<
- LVDS_BL_MOD_LEVEL_SHIFT);
lvds_gen_cntl |= LVDS_DISPLAY_DIS;
OUTREG(LVDS_GEN_CNTL, lvds_gen_cntl);
- udelay(100);
+ udelay(1000);
lvds_gen_cntl &= ~(LVDS_ON | LVDS_EN);
OUTREG(LVDS_GEN_CNTL, lvds_gen_cntl);
lvds_gen_cntl &= ~(LVDS_DIGON);
_
Patches currently in -mm which might be from rtdrury@xxxxxxxxxxxxx are
fix-radeon-backlight-shutoff-flashes-momentarily.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
