The patch titled hugetlb: chg cannot become less than 0 has been added to the -mm tree. Its filename is hugetlb-chg-cannot-become-less-than-0.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: hugetlb: chg cannot become less than 0 From: Roel Kluin <roel.kluin@xxxxxxxxx> chg is unsigned, so it cannot be less than 0. Also, since region_chg returns long, let vma_needs_reservation() forward this to alloc_huge_page(). Store it as long as well. all callers cast it to long anyway. Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx> Cc: Andy Whitcroft <apw@xxxxxxxxxxxx> Cc: Mel Gorman <mel@xxxxxxxxx> Cc: Adam Litke <agl@xxxxxxxxxx> Cc: Johannes Weiner <hannes@xxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/hugetlb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -puN mm/hugetlb.c~hugetlb-chg-cannot-become-less-than-0 mm/hugetlb.c --- a/mm/hugetlb.c~hugetlb-chg-cannot-become-less-than-0 +++ a/mm/hugetlb.c @@ -918,7 +918,7 @@ static void return_unused_surplus_pages( * an instantiated the change should be committed via vma_commit_reservation. * No action is required on failure. */ -static int vma_needs_reservation(struct hstate *h, +static long vma_needs_reservation(struct hstate *h, struct vm_area_struct *vma, unsigned long addr) { struct address_space *mapping = vma->vm_file->f_mapping; @@ -933,7 +933,7 @@ static int vma_needs_reservation(struct return 1; } else { - int err; + long err; pgoff_t idx = vma_hugecache_offset(h, vma, addr); struct resv_map *reservations = vma_resv_map(vma); @@ -969,7 +969,7 @@ static struct page *alloc_huge_page(stru struct page *page; struct address_space *mapping = vma->vm_file->f_mapping; struct inode *inode = mapping->host; - unsigned int chg; + long chg; /* * Processes that did not create the mapping will have no reserves and _ Patches currently in -mm which might be from roel.kluin@xxxxxxxxx are origin.patch linux-next.patch acpi-get_throttling_state-cannot-be-larger-state_count.patch drm-fix-lock_test_with_return-macro.patch dvb-negative-internal-sub_range-wont-get-noticed.patch scsi-ncr53c8xx-div-reaches-1.patch scsi-pcmcia-nsp_cs-time_out-reaches-1.patch mm-get_nid_for_pfn-returns-int.patch hugetlb-chg-cannot-become-less-than-0.patch frv-duplicate-output_buffer-of-e03.patch frv-duplicate-output_buffer-of-e03-checkpatch-fixes.patch alpha-fix-macros.patch m68k-count-can-reach-51-not-50.patch m68k-count-can-reach-51-not-50-checkpatch-fixes.patch spi-limit-reaches-1-tested-0.patch rtc-wm8350-retries-will-reach-1.patch fbdev-newport-newport_wait-return-0-on-timeout.patch drivers-video-omap-hwa742c-div-reaches-max_clk_div.patch arkfb-fix-misplaced-parentheses.patch uvesafb-bitwise-or-has-higher-precedence-than.patch vesafb-bitwise-or-has-higher-precedence-than.patch viafb-returns-0-two-too-early.patch ufs-sector_t-cannot-be-negative.patch rio-addition-has-higher-precedence-than.patch aoe-error-printed-1-too-early.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html