The patch titled
driver core: remove polling for driver_probe_done(v5)
has been added to the -mm tree. Its filename is
driver-core-remove-polling-for-driver_probe_donev5.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: driver core: remove polling for driver_probe_done(v5)
From: Ming Lei <tom.leiming@xxxxxxxxx>
Remove the 100ms polling for driver_probe_done in wait_for_device_probe(),
and uses wait_event() instead. Removing polling in fs initialization may
lead to a faster boot.
This patch also changes the return type of wait_for_device_done() from int
to void.
This patch is against Arjan's patch in linux-next tree.
Signed-off-by: Ming Lei <tom.leiming@xxxxxxxxx>
Acked-by: Cornelia Huck <cornelia.huck@xxxxxxxxxx>
Reviewed-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
Cc: Kay Sievers <kay.sievers@xxxxxxxx>
Cc: Greg KH <greg@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/base/dd.c | 8 ++------
include/linux/device.h | 2 +-
2 files changed, 3 insertions(+), 7 deletions(-)
diff -puN drivers/base/dd.c~driver-core-remove-polling-for-driver_probe_donev5 drivers/base/dd.c
--- a/drivers/base/dd.c~driver-core-remove-polling-for-driver_probe_donev5
+++ a/drivers/base/dd.c
@@ -172,16 +172,12 @@ int driver_probe_done(void)
/**
* wait_for_device_probe
* Wait for device probing to be completed.
- *
- * Note: this function polls at 100 msec intervals.
*/
-int wait_for_device_probe(void)
+void wait_for_device_probe(void)
{
/* wait for the known devices to complete their probing */
- while (driver_probe_done() != 0)
- msleep(100);
+ wait_event(probe_waitqueue, atomic_read(&probe_count) == 0);
async_synchronize_full();
- return 0;
}
/**
diff -puN include/linux/device.h~driver-core-remove-polling-for-driver_probe_donev5 include/linux/device.h
--- a/include/linux/device.h~driver-core-remove-polling-for-driver_probe_donev5
+++ a/include/linux/device.h
@@ -148,7 +148,7 @@ extern void put_driver(struct device_dri
extern struct device_driver *driver_find(const char *name,
struct bus_type *bus);
extern int driver_probe_done(void);
-extern int wait_for_device_probe(void);
+extern void wait_for_device_probe(void);
/* sysfs interface for exporting driver attributes */
_
Patches currently in -mm which might be from tom.leiming@xxxxxxxxx are
linux-next.patch
driver-core-remove-polling-for-driver_probe_donev5.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
