The patch titled
vfs: add set_page_dirty_notag()
has been added to the -mm tree. Its filename is
vfs-add-set_page_dirty_notag.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: vfs: add set_page_dirty_notag()
From: Edward Shishkin <edward.shishkin@xxxxxxxxx>
In accordance with reiser4 transactional model every dirty page should be
"captured" by some atom. However, outside reiser4 context dirty page can
not be captured in some cases, as it is accompanied with specific work
(jnode creation, etc). Reiser4 recognizes such "anonymous" pages (i.e.
pages that were dirtied outside of reiser4) by the tag
PAGECACHE_TAG_DIRTY. Pages dirtied inside reiser4 context are not tagged
at all: we don't need this. Indeed, once page is dirtied and captured, it
is attached to a jnode (a special header to keep a track of transactions).
reiser4_set_page_dirty_internal() was the internal reiser4 function that
set dirty bit without tagging the page. Having such internal function led
to real problems (incorrect task io accounting, etc. because of not
updating this internal "friend").
Solution:
The following patch adds a core library function that sets a dirty bit
without tagging the page. It should be modified simultaneously with its
"friends": __set_page_dirty_nobuffers, __set_page_dirty.
Signed-off-by: Edward Shishkin<edward.shishkin@xxxxxxxxx>
Acked-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
Acked-by: Nick Piggin <npiggin@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
include/linux/mm.h | 1 +
mm/page-writeback.c | 36 ++++++++++++++++++++++++++++++++++++
2 files changed, 37 insertions(+)
diff -puN include/linux/mm.h~vfs-add-set_page_dirty_notag include/linux/mm.h
--- a/include/linux/mm.h~vfs-add-set_page_dirty_notag
+++ a/include/linux/mm.h
@@ -841,6 +841,7 @@ int redirty_page_for_writepage(struct wr
struct page *page);
int set_page_dirty(struct page *page);
int set_page_dirty_lock(struct page *page);
+int set_page_dirty_notag(struct page *page);
int clear_page_dirty_for_io(struct page *page);
extern unsigned long move_page_tables(struct vm_area_struct *vma,
diff -puN mm/page-writeback.c~vfs-add-set_page_dirty_notag mm/page-writeback.c
--- a/mm/page-writeback.c~vfs-add-set_page_dirty_notag
+++ a/mm/page-writeback.c
@@ -1248,6 +1248,42 @@ int __set_page_dirty_nobuffers(struct pa
EXPORT_SYMBOL(__set_page_dirty_nobuffers);
/*
+ * set_page_dirty_notag() -- similar to __set_page_dirty_nobuffers()
+ * except it doesn't tag the page dirty in the page-cache radix tree.
+ * This means that the address space using this cannot use the regular
+ * filemap ->writepages() helpers and must provide its own means of
+ * tracking and finding non-tagged dirty pages.
+ *
+ * NOTE: furthermore, this version also doesn't handle truncate races.
+ */
+int set_page_dirty_notag(struct page *page)
+{
+ struct address_space *mapping = page->mapping;
+
+ if (!TestSetPageDirty(page)) {
+ WARN_ON_ONCE(!PagePrivate(page) && !PageUptodate(page));
+ if (mapping_cap_account_dirty(mapping)) {
+ /*
+ * The accounting functions rely on
+ * being atomic wrt interrupts.
+ */
+ unsigned long flags;
+ local_irq_save(flags);
+ __inc_zone_page_state(page, NR_FILE_DIRTY);
+ __inc_bdi_stat(mapping->backing_dev_info,
+ BDI_RECLAIMABLE);
+ task_dirty_inc(current);
+ task_io_account_write(PAGE_CACHE_SIZE);
+ local_irq_restore(flags);
+ }
+ __mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
+ return 1;
+ }
+ return 0;
+}
+EXPORT_SYMBOL(set_page_dirty_notag);
+
+/*
* When a writepage implementation decides that it doesn't want to write this
* page for some reason, it should redirty the locked page via
* redirty_page_for_writepage() and it should then unlock the page and return 0
_
Patches currently in -mm which might be from edward.shishkin@xxxxxxxxx are
vfs-add-set_page_dirty_notag.patch
reiser4-vfs-add-super_operationssync_inodes-2.patch
reiser4.patch
reiser4-adjust-to-the-new-aops.patch
reiser4-adjust-to-the-new-aops-fixup.patch
reiser4-remove-simple_prepare_write-usage.patch
reiser4-remove-simple_prepare_write-usage-checkpatch-fixes.patch
reiser4-handling-error-returned-by-d_obtain_alias-fixup.patch
reiser4-update-names-of-quota-methods.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
