The patch titled
tty: pty: lookup retval fixup
has been added to the -mm tree. Its filename is
tty-pty-lookup-retval-fixup.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: tty: pty: lookup retval fixup
From: Jiri Slaby <jirislaby@xxxxxxxxx>
Make sure we fail on NULL return value possibly returned by master tty
lookup.
Convert NULL to ERR_PTR(-ENODEV) in ptm_unix98_lookup, since NULL is not
captured by IS_ERR() in __tty_open.
Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>
Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/char/pty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/char/pty.c~tty-pty-lookup-retval-fixup drivers/char/pty.c
--- a/drivers/char/pty.c~tty-pty-lookup-retval-fixup
+++ a/drivers/char/pty.c
@@ -508,7 +508,7 @@ static struct tty_struct *ptm_unix98_loo
struct tty_struct *tty = devpts_get_tty(ptm_inode, idx);
if (tty)
tty = tty->link;
- return tty;
+ return tty ? : ERR_PTR(-ENODEV);
}
/**
_
Patches currently in -mm which might be from jirislaby@xxxxxxxxx are
linux-next.patch
tty-pty-lookup-retval-fixup.patch
reiser4.patch
shrink_slab-handle-bad-shrinkers.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
