The patch titled checkpatch: extend attribute testing to all modifiers has been added to the -mm tree. Its filename is checkpatch-extend-attribute-testing-to-all-modifiers.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: checkpatch: extend attribute testing to all modifiers From: Andy Whitcroft <apw@xxxxxxxxxxxxx> We should allow testing of all modifiers not just attributes. Extend testing and test for all the know modifiers. Signed-off-by: Andy Whitcroft <apw@xxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- scripts/checkpatch.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN scripts/checkpatch.pl~checkpatch-extend-attribute-testing-to-all-modifiers scripts/checkpatch.pl --- a/scripts/checkpatch.pl~checkpatch-extend-attribute-testing-to-all-modifiers +++ a/scripts/checkpatch.pl @@ -1584,9 +1584,9 @@ sub process { } # TEST: allow direct testing of the attribute matcher. if ($dbg_attr) { - if ($line =~ /^.\s*$Attribute\s*$/) { + if ($line =~ /^.\s*$Modifier\s*$/) { ERROR("TEST: is attr\n" . $herecurr); - } elsif ($dbg_attr > 1 && $line =~ /^.+($Attribute)/) { + } elsif ($dbg_attr > 1 && $line =~ /^.+($Modifier)/) { ERROR("TEST: is not attr ($1 is)\n". $herecurr); } next; _ Patches currently in -mm which might be from apw@xxxxxxxxxxxxx are mmc-add-modalias-linkage-for-mmc-sd-devices.patch checkpatch-make-in_atomic-ok-in-the-core.patch checkpatch-do-not-warn-about-p0-patches-when-checking-files.patch checkpatch-correctly-handle-type-spacing-in-the-face-of-modifiers.patch checkpatch-pointer-type-star-may-have-modifiers-following.patch checkpatch-a-modifier-is-not-an-identifier-at-the-end-of-a-type.patch checkpatch-extend-attribute-testing-to-all-modifiers.patch checkpatch-add-__ref-as-a-sparse-modifier.patch checkpatch-version-028.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html