The patch titled checkpatch: struct seq_operations should normally be const has been added to the -mm tree. Its filename is checkpatch-struct-seq_operations-should-normally-be-const.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: checkpatch: struct seq_operations should normally be const From: Andy Whitcroft <apw@xxxxxxxxxxxxx> In the general use case struct seq_operations should be a const object. Check for and warn where it is not. Cc: Ingo Molnar <mingo@xxxxxxx> Signed-off-by: Andy Whitcroft <apw@xxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- scripts/checkpatch.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff -puN scripts/checkpatch.pl~checkpatch-struct-seq_operations-should-normally-be-const scripts/checkpatch.pl --- a/scripts/checkpatch.pl~checkpatch-struct-seq_operations-should-normally-be-const +++ a/scripts/checkpatch.pl @@ -2527,9 +2527,10 @@ sub process { WARN("please use device_initcall() instead of __initcall()\n" . $herecurr); } # check for struct file_operations, ensure they are const. - if ($line =~ /\bstruct\s+file_operations\b/ && - $line !~ /\bconst\b/) { - WARN("struct file_operations should normally be const\n" . $herecurr); + if ($line !~ /\bconst\b/ && + $line =~ /\bstruct\s+(file_operations|seq_operations)\b/) { + WARN("struct $1 should normally be const\n" . + $herecurr); } # use of NR_CPUS is usually wrong _ Patches currently in -mm which might be from apw@xxxxxxxxxxxxx are sysrq-documentation-remove-the-redundant-updated-date.patch sysrq-documentation-document-why-the-command-header-only-is-shown.patch sysrq-add-commentary-on-why-we-use-the-console-loglevel-over-using-kern_emerg.patch checkpatch-handle-missing-if-open-in-context.patch checkpatch-type-cast-spacing-should-not-check-prefix-spacing.patch checkpatch-allow-parentheses-on-return-handle-array-values.patch checkpatch-if-should-not-continue-a-preceeding-brace.patch checkpatch-struct-seq_operations-should-normally-be-const.patch checkpatch-version-027.patch mmc-add-modalias-linkage-for-mmc-sd-devices.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html