The patch titled sysrq: add commentary on why we use the console loglevel over using KERN_EMERG has been added to the -mm tree. Its filename is sysrq-add-commentary-on-why-we-use-the-console-loglevel-over-using-kern_emerg.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: sysrq: add commentary on why we use the console loglevel over using KERN_EMERG From: Andy Whitcroft <apw@xxxxxxxxxxxxx> Add an explanitory comment as to why we modify the kernel console loglevel rather than simply moving sysrq messages to KERN_EMERG level. Signed-off-by: Andy Whitcroft <apw@xxxxxxxxxxxxx> Cc: Randy Dunlap <randy.dunlap@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/char/sysrq.c | 6 ++++++ 1 file changed, 6 insertions(+) diff -puN drivers/char/sysrq.c~sysrq-add-commentary-on-why-we-use-the-console-loglevel-over-using-kern_emerg drivers/char/sysrq.c --- a/drivers/char/sysrq.c~sysrq-add-commentary-on-why-we-use-the-console-loglevel-over-using-kern_emerg +++ a/drivers/char/sysrq.c @@ -473,6 +473,12 @@ void __handle_sysrq(int key, struct tty_ unsigned long flags; spin_lock_irqsave(&sysrq_key_table_lock, flags); + /* + * Raise the apparent loglevel to maximum so that the sysrq header + * is shown to provide the user with positive feedback. We do not + * simply emit this at KERN_EMERG as that would change message + * routing in the consumers of /proc/kmsg. + */ orig_log_level = console_loglevel; console_loglevel = 7; printk(KERN_INFO "SysRq : "); _ Patches currently in -mm which might be from apw@xxxxxxxxxxxxx are mmc-add-modalias-linkage-for-mmc-sd-devices.patch sysrq-documentation-remove-the-redundant-updated-date.patch sysrq-documentation-document-why-the-command-header-only-is-shown.patch sysrq-add-commentary-on-why-we-use-the-console-loglevel-over-using-kern_emerg.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html