The patch titled drivers/mmc: move a dereference below a NULL test has been removed from the -mm tree. Its filename was drivers-mmc-move-a-dereference-below-a-null-test.patch This patch was dropped because it was merged into mainline or a subsystem tree The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: drivers/mmc: move a dereference below a NULL test From: Julia Lawall <julia@xxxxxxx> In each case, if the NULL test is necessary, then the dereference should be moved below the NULL test. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ type T; expression E; identifier i,fld; statement S; @@ - T i = E->fld; + T i; ... when != E when != i if (E == NULL) S + i = E->fld; // </smpl> Signed-off-by: Julia Lawall <julia@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/mmc/host/tmio_mmc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -puN drivers/mmc/host/tmio_mmc.c~drivers-mmc-move-a-dereference-below-a-null-test drivers/mmc/host/tmio_mmc.c --- a/drivers/mmc/host/tmio_mmc.c~drivers-mmc-move-a-dereference-below-a-null-test +++ a/drivers/mmc/host/tmio_mmc.c @@ -224,7 +224,7 @@ static inline void tmio_mmc_data_irq(str { void __iomem *ctl = host->ctl; struct mmc_data *data = host->data; - struct mmc_command *stop = data->stop; + struct mmc_command *stop; host->data = NULL; @@ -232,6 +232,7 @@ static inline void tmio_mmc_data_irq(str pr_debug("Spurious data end IRQ\n"); return; } + stop = data->stop; /* FIXME - return correct transfer count on errors */ if (!data->error) _ Patches currently in -mm which might be from julia@xxxxxxx are origin.patch linux-next.patch arch-avr32-eliminate-null-test-and-memset-after-alloc_bootmem.patch powerpc-powermac-add-missing-of_node_put.patch net-tipc-bcasth-use-array_size.patch net-bridge-netfilter-move-a-dereference-below-a-null-test.patch drivers-isdn-hardware-misdn-move-a-dereference-below-a-null-test.patch drivers-net-hamradio-6packc-move-a-dereference-below-a-null-test.patch drivers-net-wireless-libertas-move-a-dereference-below-a-null-test.patch drivers-scsi-move-a-dereference-below-a-null-test.patch fs-namespacec-drop-code-after-return.patch mm-page_allocc-eliminate-null-test-and-memset-after-alloc_bootmem.patch drivers-macintosh-add-missing-of_node_put-in-therm_adt746xc.patch drivers-spi-move-a-dereference-below-a-null-test.patch drivers-rtc-correct-an-error-test.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html