The patch titled
w1: fix slave selection on big-endian systems
has been added to the -mm tree. Its filename is
w1-fix-slave-selection-on-big-endian-systems.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: w1: fix slave selection on big-endian systems
From: Evgeniy Polyakov <johnpol@xxxxxxxxxxx>
During test of the w1-gpio driver i found that in "w1.c:679
w1_slave_found()" the device id is converted to little-endian with
"cpu_to_le64()", but its not converted back to cpu format in "w1_io.c:293
w1_reset_select_slave()".
Based on a patch created by Andreas Hummel.
Reported-by: Andreas Hummel <andi_hummel@xxxxxx>
Signed-off-by: Evgeniy Polyakov <zbr@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/w1/w1_io.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -puN drivers/w1/w1_io.c~w1-fix-slave-selection-on-big-endian-systems drivers/w1/w1_io.c
--- a/drivers/w1/w1_io.c~w1-fix-slave-selection-on-big-endian-systems
+++ a/drivers/w1/w1_io.c
@@ -356,7 +356,9 @@ int w1_reset_select_slave(struct w1_slav
w1_write_8(sl->master, W1_SKIP_ROM);
else {
u8 match[9] = {W1_MATCH_ROM, };
- memcpy(&match[1], (u8 *)&sl->reg_num, 8);
+ u64 rn = le64_to_cpu(*((u64*)&sl->reg_num));
+
+ memcpy(&match[1], (u8 *)&rn, 8);
w1_write_block(sl->master, match, 9);
}
return 0;
_
Patches currently in -mm which might be from johnpol@xxxxxxxxxxx are
w1-fix-slave-selection-on-big-endian-systems.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
