The patch titled
i8k: add support for Dell XPS M1530
has been added to the -mm tree. Its filename is
i8k-add-support-for-dell-xps-m1530.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: i8k: add support for Dell XPS M1530
From: "Andrew Paprocki" <andrew@xxxxxxxxxxx>
I see two problems with the i8k module and the Dell XPS M1530. First, the
laptop is not detected. Second, even if it is detected, the module prints
that it is unable to get the SMM BIOS version even though the module
appears to be working:
# modprobe i8k force=1
# dmesg | grep i8k
[ 547.007217] i8k: not running on a supported Dell system.
[ 547.007234] i8k: vendor=Dell Inc., model=XPS M1530
, version=A08
[ 547.007629] i8k: unable to get SMM BIOS version
# cat /proc/i8k
1.0 A08 5D26YF1 53 0 0 0 0 -1 -22
Information from DMI:
BIOS Information
Vendor: Dell Inc.
Version: A08
Release Date: 03/19/2008
System Information
Manufacturer: Dell Inc.
Product Name: XPS M1530
It seems straightforward to add a record for the auto-detection, but I'm
not sure how generic it should be. From looking online, it appears the
M1330, M1530, and M1730 all need to be detected. Perhaps it should just
be "Dell XPS M Series" and only match on "XPS M"?
Cc: Massimo Dal Zotto <dz@xxxxxxxxxx>
Cc: Dmitry Torokhov <dtor@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/char/i8k.c | 7 +++++++
1 file changed, 7 insertions(+)
diff -puN drivers/char/i8k.c~i8k-add-support-for-dell-xps-m1530 drivers/char/i8k.c
--- a/drivers/char/i8k.c~i8k-add-support-for-dell-xps-m1530
+++ a/drivers/char/i8k.c
@@ -499,6 +499,13 @@ static struct dmi_system_id __initdata i
DMI_MATCH(DMI_PRODUCT_NAME, "Precision"),
},
},
+ {
+ .ident = "Dell XPS M1530",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "XPS M1530"),
+ },
+ },
{ }
};
_
Patches currently in -mm which might be from andrew@xxxxxxxxxxx are
i8k-add-support-for-dell-vostro.patch
i8k-add-support-for-dell-precisions.patch
i8k-add-support-for-dell-xps-m1530.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
