The patch titled
fs: fix name overwrite in __register_chrdev_region()
has been added to the -mm tree. Its filename is
fs-fix-name-overwrite-in-__register_chrdev_region.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: fs: fix name overwrite in __register_chrdev_region()
From: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
It's possible to register a chrdev with a name size exactly the same as
was allocated in structure. It seems it was not intended behaviour.
At least chrdev_show does not like it.
Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/char_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN fs/char_dev.c~fs-fix-name-overwrite-in-__register_chrdev_region fs/char_dev.c
--- a/fs/char_dev.c~fs-fix-name-overwrite-in-__register_chrdev_region
+++ a/fs/char_dev.c
@@ -120,7 +120,7 @@ __register_chrdev_region(unsigned int ma
cd->major = major;
cd->baseminor = baseminor;
cd->minorct = minorct;
- strncpy(cd->name,name, 64);
+ strlcpy(cd->name, name, sizeof(cd->name));
i = major_to_index(major);
_
Patches currently in -mm which might be from gorcunov@xxxxxxxxx are
slob-do-not-pass-the-slab-flags-as-gfp-in-kmem_cache_create.patch
linux-next.patch
net-ppp_asynctty_ioctl-remove-dead-code.patch
fs-fix-name-overwrite-in-__register_chrdev_region.patch
memcg-add-inactive_anon_is_low.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
