The patch titled checkpatch: loosen spacing on typedef function checks has been added to the -mm tree. Its filename is checkpatch-loosen-spacing-on-typedef-function-checks.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: checkpatch: loosen spacing on typedef function checks From: Andy Whitcroft <apw@xxxxxxxxxxxxx> Loosen spacing checks to correctly detect this valid use of a typedef: typedef struct rcu_data *(*get_data_func)(int); Signed-off-by: Andy Whitcroft <apw@xxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN scripts/checkpatch.pl~checkpatch-loosen-spacing-on-typedef-function-checks scripts/checkpatch.pl --- a/scripts/checkpatch.pl~checkpatch-loosen-spacing-on-typedef-function-checks +++ a/scripts/checkpatch.pl @@ -1618,7 +1618,7 @@ sub process { # check for new typedefs, only function parameters and sparse annotations # make sense. if ($line =~ /\btypedef\s/ && - $line !~ /\btypedef\s+$Type\s+\(\s*\*?$Ident\s*\)\s*\(/ && + $line !~ /\btypedef\s+$Type\s*\(\s*\*?$Ident\s*\)\s*\(/ && $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ && $line !~ /\b$typeTypedefs\b/ && $line !~ /\b__bitwise(?:__|)\b/) { _ Patches currently in -mm which might be from apw@xxxxxxxxxxxxx are linux-next.patch checkpatch-update-copyrights.patch checkpatch-add-warning-for-p0-patches.patch checkpatch-allow-parentheses-on-return-for-comparisons.patch checkpatch-try-to-catch-missing-vmlinux_symbol-in-vmlinuxldsh.patch checkpatch-loosen-spacing-on-typedef-function-checks.patch checkpatch-fix-continuation-detection-when-handling-spacing-on-operators.patch checkpatch-track-ifdef-else-endif-when-tracking-blocks.patch checkpatch-do-not-report-nr_static-as-a-static-declaration.patch checkpatch-ensure-we-actually-detect-if-assignments-split-across-lines.patch checkpatch-struct-file_operations-should-normally-be-const.patch checkpatch-fix-the-perlcritic-errors.patch checkpatch-version-026.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html