The patch titled romfs: romfs_iget() - unsigned ino >= 0 is always true has been added to the -mm tree. Its filename is romfs-romfs_iget-unsigned-ino-=-0-is-always-true.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: romfs: romfs_iget() - unsigned ino >= 0 is always true From: roel kluin <roel.kluin@xxxxxxxxx> romfs_strnlen() returns int unsigned X >= 0 is always true Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/romfs/inode.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff -puN fs/romfs/inode.c~romfs-romfs_iget-unsigned-ino-=-0-is-always-true fs/romfs/inode.c --- a/fs/romfs/inode.c~romfs-romfs_iget-unsigned-ino-=-0-is-always-true +++ a/fs/romfs/inode.c @@ -490,7 +490,7 @@ static mode_t romfs_modemap[] = static struct inode * romfs_iget(struct super_block *sb, unsigned long ino) { - int nextfh; + int nextfh, ret; struct romfs_inode ri; struct inode *i; @@ -527,9 +527,9 @@ romfs_iget(struct super_block *sb, unsig i->i_uid = i->i_gid = 0; /* Precalculate the data offset */ - ino = romfs_strnlen(i, ino+ROMFH_SIZE, ROMFS_MAXFN); - if (ino >= 0) - ino = ((ROMFH_SIZE+ino+1+ROMFH_PAD)&ROMFH_MASK); + ret = romfs_strnlen(i, ino+ROMFH_SIZE, ROMFS_MAXFN); + if (ret >= 0) + ino = ((ROMFH_SIZE+ret+1+ROMFH_PAD)&ROMFH_MASK); else ino = 0; _ Patches currently in -mm which might be from roel.kluin@xxxxxxxxx are linux-next.patch gbefb-unsigned-var-pixclock-cannot-be-less-than-0.patch sm501-unsigned-ptr-cannot-be-negative.patch ufs-sector_t-cannot-be-negative.patch romfs-romfs_iget-unsigned-ino-=-0-is-always-true.patch make-various-things-static.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html