The patch titled
net: ppp_asynctty_ioctl - remove dead code
has been added to the -mm tree. Its filename is
net-ppp_asynctty_ioctl-remove-dead-code.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: net: ppp_asynctty_ioctl - remove dead code
From: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
ap already checked to be not null. remove useless checks.
Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
Cc: Paul Mackerras <paulus@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/net/ppp_async.c | 6 ------
1 file changed, 6 deletions(-)
diff -puN drivers/net/ppp_async.c~net-ppp_asynctty_ioctl-remove-dead-code drivers/net/ppp_async.c
--- a/drivers/net/ppp_async.c~net-ppp_asynctty_ioctl-remove-dead-code
+++ a/drivers/net/ppp_async.c
@@ -293,9 +293,6 @@ ppp_asynctty_ioctl(struct tty_struct *tt
err = -EFAULT;
switch (cmd) {
case PPPIOCGCHAN:
- err = -ENXIO;
- if (!ap)
- break;
err = -EFAULT;
if (put_user(ppp_channel_index(&ap->chan), p))
break;
@@ -303,9 +300,6 @@ ppp_asynctty_ioctl(struct tty_struct *tt
break;
case PPPIOCGUNIT:
- err = -ENXIO;
- if (!ap)
- break;
err = -EFAULT;
if (put_user(ppp_unit_number(&ap->chan), p))
break;
_
Patches currently in -mm which might be from gorcunov@xxxxxxxxx are
linux-next.patch
net-ppp_asynctty_ioctl-remove-dead-code.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
