The patch titled ufs: sector_t cannot be negative has been added to the -mm tree. Its filename is ufs-sector_t-cannot-be-negative.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: ufs: sector_t cannot be negative From: Roel Kluin <roel.kluin@xxxxxxxxx> unsigned i_block,fragment cannot be negative. Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx> Signed-off-by: Evgeniy Dushistov <dushistov@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/ufs/inode.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff -puN fs/ufs/inode.c~ufs-sector_t-cannot-be-negative fs/ufs/inode.c --- a/fs/ufs/inode.c~ufs-sector_t-cannot-be-negative +++ a/fs/ufs/inode.c @@ -56,9 +56,7 @@ static int ufs_block_to_path(struct inod UFSD("ptrs=uspi->s_apb = %d,double_blocks=%ld \n",ptrs,double_blocks); - if (i_block < 0) { - ufs_warning(inode->i_sb, "ufs_block_to_path", "block < 0"); - } else if (i_block < direct_blocks) { + if (i_block < direct_blocks) { offsets[n++] = i_block; } else if ((i_block -= direct_blocks) < indirect_blocks) { offsets[n++] = UFS_IND_BLOCK; @@ -440,8 +438,6 @@ int ufs_getfrag_block(struct inode *inod lock_kernel(); UFSD("ENTER, ino %lu, fragment %llu\n", inode->i_ino, (unsigned long long)fragment); - if (fragment < 0) - goto abort_negative; if (fragment > ((UFS_NDADDR + uspi->s_apb + uspi->s_2apb + uspi->s_3apb) << uspi->s_fpbshift)) @@ -504,10 +500,6 @@ abort: unlock_kernel(); return err; -abort_negative: - ufs_warning(sb, "ufs_get_block", "block < 0"); - goto abort; - abort_too_big: ufs_warning(sb, "ufs_get_block", "block > big"); goto abort; _ Patches currently in -mm which might be from roel.kluin@xxxxxxxxx are linux-next.patch ufs-sector_t-cannot-be-negative.patch make-various-things-static.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html