- detect-atomic-counter-underflows.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     detect atomic counter underflows
has been removed from the -mm tree.  Its filename was
     detect-atomic-counter-underflows.patch

This patch was dropped because I got tired of chasing files all around the tree

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: detect atomic counter underflows
From: Ingo Molnar <mingo@xxxxxxx>

The patch below will detect atomic counter underflows.  This has been
test-driven in the -RT patchset for some time.  qdisc_destroy() triggered
it sometimes (in a seemingly nonfatal way, during device shutdown) - with
DaveM suggesting that it is most likely a bug in the networking code.  So
it would be nice to have this in -mm for some time to validate all atomic
counters on a broader base.

Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 include/asm-x86/atomic_32.h |    5 +++++
 1 file changed, 5 insertions(+)

diff -puN include/asm-x86/atomic_32.h~detect-atomic-counter-underflows include/asm-x86/atomic_32.h
--- a/include/asm-x86/atomic_32.h~detect-atomic-counter-underflows
+++ a/include/asm-x86/atomic_32.h
@@ -113,6 +113,11 @@ static inline int atomic_dec_and_test(at
 {
 	unsigned char c;
 
+	if (!atomic_read(v)) {
+		printk("BUG: atomic counter underflow at:\n");
+		dump_stack();
+	}
+
 	asm volatile(LOCK_PREFIX "decl %0; sete %1"
 		     : "+m" (v->counter), "=qm" (c)
 		     : : "memory");
_

Patches currently in -mm which might be from mingo@xxxxxxx are

linux-next.patch
x86-remove-init_mm-export-as-planned-for-2626.patch
arch-x86-kernel-setupc-omit-dmi_low_memory_corruption-when-it-is-unneeded.patch
kvmclockc-fix-section-mismatch-warning.patch
mutex-improve-header-comment-to-be-actually-informative-about-the-api.patch
mm-cleanup-to-make-remove_memory-arch-neutral-fix-fix.patch
mm-invoke-oom-killer-from-page-fault.patch
mm-invoke-oom-killer-from-page-fault-fix.patch
detect-atomic-counter-underflows.patch
make-frame_pointer-default=y.patch
mutex-subsystem-synchro-test-module.patch
likely-profiling-disable-ftrace.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux